Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grafana: add region heartbeat duration breakdown metrics #7921

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Mar 14, 2024

What problem does this PR solve?

Issue Number: Close #7868

What is changed and how does it work?

grafana: add region heartbeat duration breakdown metrics 

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    image

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Mar 14, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 14, 2024
@ti-chi-bot ti-chi-bot bot requested review from JmPotato and Yisaer March 14, 2024 08:18
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 14, 2024
@nolouch nolouch requested review from rleungx and HuSharp and removed request for Yisaer March 14, 2024 08:19
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Merging #7921 (251d379) into master (6ee25f9) will decrease coverage by 0.10%.
The diff coverage is n/a.

❗ Current head 251d379 differs from pull request most recent head f3c6fb3. Consider uploading reports for the commit f3c6fb3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7921      +/-   ##
==========================================
- Coverage   73.57%   73.48%   -0.10%     
==========================================
  Files         436      436              
  Lines       48351    48342       -9     
==========================================
- Hits        35574    35522      -52     
- Misses       9721     9763      +42     
- Partials     3056     3057       +1     
Flag Coverage Δ
unittests 73.48% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 14, 2024
@nolouch nolouch added the require-LGT1 Indicates that the PR requires an LGTM. label Mar 15, 2024
@nolouch
Copy link
Contributor Author

nolouch commented Mar 15, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Mar 15, 2024

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Mar 15, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 251d379

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 15, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 15, 2024

@nolouch: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 83a5966 into tikv:master Mar 15, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Heartbeat trace statistics help analyze performance bottlenecks
2 participants