Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dashboard): update TiDB Dashboard to v8.0.0-ab48e09f [master] #7924

Conversation

baurine
Copy link
Contributor

@baurine baurine commented Mar 15, 2024

What problem does this PR solve?

Issue Number: ref #4257

Update TiDB Dashboard to v8.0.0-ab48e09f.

Release note

None

Test

make pd-server
cp ./bin/pd-server ~/.tiup/components/pd/v8.0.0-alpha-nightly/
tiup playground nightly --pd.mode ms --pd.api 1 --pd.scheduling 1 --pd.tso 1 --pd.rm 0 --kv 3 --tiflash 0 --db 1 

image

Copy link
Contributor

ti-chi-bot bot commented Mar 15, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Mar 15, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 15, 2024

Hi @baurine. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot requested review from JmPotato and rleungx March 15, 2024 08:45
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 15, 2024
@baurine
Copy link
Contributor Author

baurine commented Mar 15, 2024

after #7923 is merged, found a bug in tidb-dashboard ( pingcap/tidb-dashboard#1656 ), just fixed it and release a new tidb-dashboard version.

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Merging #7924 (31ddda9) into master (da97f9c) will decrease coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7924      +/-   ##
==========================================
- Coverage   73.55%   73.50%   -0.05%     
==========================================
  Files         436      436              
  Lines       48351    48351              
==========================================
- Hits        35564    35542      -22     
- Misses       9727     9747      +20     
- Partials     3060     3062       +2     
Flag Coverage Δ
unittests 73.50% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 15, 2024
@rleungx
Copy link
Member

rleungx commented Mar 15, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Mar 15, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 17, 2024
@nolouch
Copy link
Contributor

nolouch commented Mar 17, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Mar 17, 2024

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Mar 17, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 31ddda9

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 17, 2024
@ti-chi-bot ti-chi-bot bot merged commit 5ebef84 into tikv:master Mar 17, 2024
26 of 27 checks passed
@baurine baurine deleted the update-tidb-dashboard/master-v8.0.0-ab48e09f-1710492332 branch March 18, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants