Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: remove failed request metrics for background setting query #7925

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

CabinfeverB
Copy link
Member

@CabinfeverB CabinfeverB commented Mar 18, 2024

What problem does this PR solve?

Issue Number: Close #7926

What is changed and how does it work?

Check List

Tests

  • Unit test

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Mar 18, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Mar 18, 2024
@ti-chi-bot ti-chi-bot bot requested review from nolouch and Yisaer March 18, 2024 05:25
@CabinfeverB CabinfeverB requested review from HuSharp and removed request for Yisaer March 18, 2024 05:25
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Merging #7925 (70a4a69) into master (5ebef84) will increase coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7925      +/-   ##
==========================================
+ Coverage   73.47%   73.53%   +0.05%     
==========================================
  Files         436      436              
  Lines       48351    48349       -2     
==========================================
+ Hits        35528    35555      +27     
+ Misses       9755     9738      -17     
+ Partials     3068     3056      -12     
Flag Coverage Δ
unittests 73.53% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 18, 2024
@HuSharp
Copy link
Member

HuSharp commented Mar 18, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Mar 18, 2024

@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Mar 18, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 70a4a69

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 18, 2024
@ti-chi-bot ti-chi-bot bot merged commit da3b6e3 into tikv:master Mar 18, 2024
26 of 27 checks passed
@CabinfeverB CabinfeverB added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Mar 18, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #7927.

ti-chi-bot bot pushed a commit that referenced this pull request Apr 1, 2024
…7925) (#7927)

close #7926

Signed-off-by: Cabinfever_B <[email protected]>

Co-authored-by: Cabinfever_B <[email protected]>
Co-authored-by: Yongbo Jiang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tidb connection panic after fault recover from one of tidb network partition
4 participants