-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/etcdutil: reduce etcdutil test time #7945
Conversation
Signed-off-by: lhy1024 <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
pkg/utils/etcdutil/etcdutil.go
Outdated
@@ -794,3 +796,7 @@ func (lw *LoopWatcher) SetLoadRetryTimes(times int) { | |||
func (lw *LoopWatcher) SetLoadBatchSize(size int64) { | |||
lw.loadBatchSize = size | |||
} | |||
|
|||
func (lw *LoopWatcher) SetWatchChTimeoutDuration(v time.Duration) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why need this function?
Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: lhy1024 <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7945 +/- ##
==========================================
+ Coverage 73.50% 73.58% +0.08%
==========================================
Files 436 436
Lines 48362 48363 +1
==========================================
+ Hits 35548 35589 +41
+ Misses 9755 9721 -34
+ Partials 3059 3053 -6
Flags with carried forward coverage won't be shown. Click here to find out more. |
/merge |
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 5a03669
|
What problem does this PR solve?
Issue Number: ref #7930
What is changed and how does it work?
Check List
Tests
local
ci
Release note