Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/etcdutil: reduce etcdutil test time #7945

Merged
merged 4 commits into from
Mar 19, 2024
Merged

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Mar 19, 2024

What problem does this PR solve?

Issue Number: ref #7930

What is changed and how does it work?

Check List

Tests

  • Unit test

local

Before 
go test -timeout 120s -run ^TestLoopWatcherTestSuite$ -testify.m ^(TestWatcherLoadLargeKey)$ github.com/tikv/pd/pkg/utils/etcdutil
ok      github.com/tikv/pd/pkg/utils/etcdutil   51.058s
After
go test -timeout 120s -run ^TestLoopWatcherTestSuite$ -testify.m ^(TestWatcherLoadLargeKey)$ github.com/tikv/pd/pkg/utils/etcdutil
ok      github.com/tikv/pd/pkg/utils/etcdutil   28.717s

ci

Before 
https://github.com/tikv/pd/actions/runs/8339040119/job/22820335714
ok  	http://github.com/tikv/pd/pkg/utils/etcdutil	208.548s 
After
https://github.com/tikv/pd/actions/runs/8339647034/job/22822028949?pr=7945
ok  	http://github.com/tikv/pd/pkg/utils/etcdutil	125.064s

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Mar 19, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • JmPotato

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 19, 2024
@ti-chi-bot ti-chi-bot bot requested review from JmPotato and rleungx March 19, 2024 08:08
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 19, 2024
@lhy1024 lhy1024 requested a review from HuSharp March 19, 2024 08:10
@@ -794,3 +796,7 @@ func (lw *LoopWatcher) SetLoadRetryTimes(times int) {
func (lw *LoopWatcher) SetLoadBatchSize(size int64) {
lw.loadBatchSize = size
}

func (lw *LoopWatcher) SetWatchChTimeoutDuration(v time.Duration) {
Copy link
Member

@HuSharp HuSharp Mar 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why need this function?

Signed-off-by: lhy1024 <[email protected]>
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Merging #7945 (5a03669) into master (3fe806a) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7945      +/-   ##
==========================================
+ Coverage   73.50%   73.58%   +0.08%     
==========================================
  Files         436      436              
  Lines       48362    48363       +1     
==========================================
+ Hits        35548    35589      +41     
+ Misses       9755     9721      -34     
+ Partials     3059     3053       -6     
Flag Coverage Δ
unittests 73.58% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 19, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 19, 2024
@JmPotato
Copy link
Member

/merge

Copy link
Contributor

ti-chi-bot bot commented Mar 19, 2024

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Mar 19, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 5a03669

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 19, 2024
@ti-chi-bot ti-chi-bot bot merged commit b0c49fa into tikv:master Mar 19, 2024
25 of 26 checks passed
@HuSharp HuSharp changed the title tests: reduce etcdutil test time tests/etcdutil: reduce etcdutil test time Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants