Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix region stats check (#7748) #7976

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7748

What problem does this PR solve?

Issue Number: Close #7728

What is changed and how does it work?

  1. isNew is useless because region source is inexact when leader transfer and no sync. Now, no need to hold isNew because saveCache must be true if the region in cache does not have leader.
  2. check whether the region is observed by its own map

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Mar 25, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 25, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • JmPotato

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 25, 2024
@ti-chi-bot ti-chi-bot bot requested review from HunDunDM and rleungx March 25, 2024 05:36
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 25, 2024
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 26, 2024
HuSharp and others added 2 commits March 27, 2024 11:59
Signed-off-by: husharp <[email protected]>
@CabinfeverB CabinfeverB force-pushed the cherry-pick-7748-to-release-6.5 branch from f52a6e1 to a9d5716 Compare March 27, 2024 05:08
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 75.46%. Comparing base (1467007) to head (3ce032a).

Files Patch % Lines
server/core/region.go 50.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-6.5    #7976      +/-   ##
===============================================
- Coverage        75.63%   75.46%   -0.18%     
===============================================
  Files              332      332              
  Lines            33784    33790       +6     
===============================================
- Hits             25553    25499      -54     
- Misses            6033     6080      +47     
- Partials          2198     2211      +13     
Flag Coverage Δ
unittests 75.46% <82.60%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 27, 2024
@CabinfeverB
Copy link
Member

/merge

Copy link
Contributor

ti-chi-bot bot commented Mar 27, 2024

@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Mar 27, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 3ce032a

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 27, 2024
@ti-chi-bot ti-chi-bot bot merged commit cb07342 into tikv:release-6.5 Mar 27, 2024
19 checks passed
@HuSharp HuSharp deleted the cherry-pick-7748-to-release-6.5 branch March 27, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants