-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix region stats check (#7748) #7976
*: fix region stats check (#7748) #7976
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: husharp <[email protected]>
close tikv#7728 Signed-off-by: Cabinfever_B <[email protected]>
f52a6e1
to
a9d5716
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #7976 +/- ##
===============================================
- Coverage 75.63% 75.46% -0.18%
===============================================
Files 332 332
Lines 33784 33790 +6
===============================================
- Hits 25553 25499 -54
- Misses 6033 6080 +47
- Partials 2198 2211 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…7748-to-release-6.5
/merge |
@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 3ce032a
|
This is an automated cherry-pick of #7748
What problem does this PR solve?
Issue Number: Close #7728
What is changed and how does it work?
isNew
is useless because region source is inexact when leader transfer and no sync. Now, no need to holdisNew
becausesaveCache
must be true if the region in cache does not have leader.Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tiup
:Release note