ttl: Trying to get float64 after get uint64 fails.

[HuSharp]

What problem does this PR solve?

Issue Number: Close #7980

What is changed and how does it work?

when set schedule.max-pending-peer-count as uint64(math.MaxInt32)

json unmarshal will convert number(uint64(math.MaxInt32)) to float64

and then set float64 into TTL config

pd/server/server.go

Line 1955 in 6ee25f9

if err := s.persistOptions.SetTTLData(s.ctx, s.client, k, fmt.Sprint(v), ttl); err != nil {

and then fmt.Sprint(float(math.MaxInt32)) will transfer float(math.MaxInt32) to 2.147483647e+09 which will meet error when try to get TTL config

[2024/03/25 06:55:50.799 +00:00] [WARN] [persist_options.go:887] ["failed to parse schedule.max-pending-peer-count from PersistOptions's ttl storage"] [error="strconv.ParseUint: parsing \"2.147483647e+09\": invalid syntax"]

and then get default value 64 which is not equal math.MaxInt32

How does this pr work?

try to parse float64 when meet parse uint64 failed

Check List

Tests

• Integration test

Release note

None.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• CabinfeverB
• lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[codecov]

Codecov Report

Merging #7979 (296c811) into master (5a24dc0) will increase coverage by 0.02%.
The diff coverage is 89.47%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7979      +/-   ##
==========================================
+ Coverage   73.53%   73.56%   +0.02%     
==========================================
  Files         436      436              
  Lines       48467    48472       +5     
==========================================
+ Hits        35641    35659      +18     
+ Misses       9760     9749      -11     
+ Partials     3066     3064       -2     

Flag	Coverage Δ
unittests	73.56% <89.47%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[lhy1024]

maybe we need to provide a util about it

[HuSharp]

transfer function name getTTLUint to getTTLNumber and add more comment

[HuSharp]

/merge

[ti-chi-bot]

@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 296c811