-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client/http: change the keyspace config name for the GC management type #8000
Conversation
Signed-off-by: [email protected] <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Hi @ystaticy. Thanks for your PR. I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Signed-off-by: [email protected] <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8000 +/- ##
=======================================
Coverage 73.64% 73.65%
=======================================
Files 436 436
Lines 48503 48474 -29
=======================================
- Hits 35722 35704 -18
+ Misses 9727 9715 -12
- Partials 3054 3055 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
/merge |
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 568190d
|
@ystaticy: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
safe_point_version
Config name in keyspace meta config make some confuse.It need be changed to
gc_management_type
.Issue Number: ref #8002
What is changed and how does it work?
If
gc_management_type
isglobal_gc
, it means the current keyspace requires a tidb without 'keyspace-name'configured to run a global gc worker to calculate a global gc safe point.
If
gc_management_type
iskeyspace_level_gc
it means the current keyspace can calculate gc safe point by its own.After update Keyspace GC management type, query keyspace meta from PD, we can get as follows:
Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tiup
:Release note