Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsafe recovery: Fix lock contention #8013

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

v01dstar
Copy link
Contributor

@v01dstar v01dstar commented Apr 1, 2024

What problem does this PR solve?

Issue Number: Close #4399

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

Signed-off-by: Yang Zhang <[email protected]>
Copy link
Contributor

ti-chi-bot bot commented Apr 1, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Connor1996
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Apr 1, 2024
@ti-chi-bot ti-chi-bot bot requested review from nolouch and rleungx April 1, 2024 22:54
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 1, 2024
Signed-off-by: Yang Zhang <[email protected]>
Copy link
Contributor

ti-chi-bot bot commented Apr 1, 2024

@tonyxuqqi: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@v01dstar
Copy link
Contributor Author

v01dstar commented Apr 1, 2024

/cc @Connor1996

@ti-chi-bot ti-chi-bot bot requested a review from Connor1996 April 1, 2024 23:23
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.73%. Comparing base (6ea3d29) to head (400cd7b).
Report is 1 commits behind head on release-7.1.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-7.1    #8013      +/-   ##
===============================================
- Coverage        74.80%   74.73%   -0.08%     
===============================================
  Files              412      412              
  Lines            41750    41738      -12     
===============================================
- Hits             31230    31191      -39     
- Misses            7773     7795      +22     
- Partials          2747     2752       +5     
Flag Coverage Δ
unittests 74.73% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 2, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 2, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 2, 2024
@nolouch
Copy link
Contributor

nolouch commented Apr 2, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Apr 2, 2024

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Apr 2, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 400cd7b

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 2, 2024
@ti-chi-bot ti-chi-bot bot merged commit 39fa88e into tikv:release-7.1 Apr 2, 2024
19 checks passed
@v01dstar v01dstar deleted the fix-lock-contention branch April 2, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants