Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: fix client and tools cover profile #8020

Merged
merged 6 commits into from
Apr 9, 2024

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Apr 3, 2024

What problem does this PR solve?

Issue Number: Ref #4399

What is changed and how does it work?

  • add client cover profile
  • make client test with failpoint

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Apr 3, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Copy link
Contributor

ti-chi-bot bot commented Apr 3, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-linked-issue labels Apr 3, 2024
@ti-chi-bot ti-chi-bot bot requested review from JmPotato and lhy1024 April 3, 2024 03:33
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Merging #8020 (550c952) into master (80a2fd9) will increase coverage by 1.33%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head 550c952 differs from pull request most recent head 3b242a4. Consider uploading reports for the commit 3b242a4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8020      +/-   ##
==========================================
+ Coverage   73.58%   74.92%   +1.33%     
==========================================
  Files         436      467      +31     
  Lines       48568    52406    +3838     
==========================================
+ Hits        35737    39263    +3526     
+ Misses       9764     9696      -68     
- Partials     3067     3447     +380     
Flag Coverage Δ
unittests 74.92% <ø> (+1.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@HuSharp HuSharp requested review from JmPotato and rleungx April 3, 2024 04:56
@HuSharp HuSharp marked this pull request as ready for review April 3, 2024 04:56
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 3, 2024
@HuSharp HuSharp force-pushed the fix_client_cov branch 2 times, most recently from 79c751d to 2552b6e Compare April 3, 2024 08:11
@HuSharp HuSharp removed the request for review from JmPotato April 3, 2024 08:12
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 3, 2024
@HuSharp HuSharp force-pushed the fix_client_cov branch 3 times, most recently from b81052f to 9dff6c5 Compare April 7, 2024 03:07
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 7, 2024
Signed-off-by: husharp <[email protected]>
@ti-chi-bot ti-chi-bot bot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 7, 2024
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 7, 2024
ci-test-job: failpoint-enable
CGO_ENABLED=1 go test ./... -v -tags deadlock -race -cover || { $(MAKE) failpoint-disable && exit 1; }
$(MAKE) failpoint-disable
ci-test-job:
Copy link
Member Author

@HuSharp HuSharp Apr 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to enable failpoint in this command, ci-test-job will turn on failpoint at the beginning.

pd/Makefile

Lines 248 to 251 in 6822137

ci-test-job: install-tools dashboard-ui
@$(FAILPOINT_ENABLE)
./scripts/ci-subtask.sh $(JOB_COUNT) $(JOB_INDEX) || { $(FAILPOINT_DISABLE); exit 1; }
@$(FAILPOINT_DISABLE)

Disabling useless commands here will reduce some of ci time

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we can run make ci-test-job in client package independently.

Copy link
Member Author

@HuSharp HuSharp Apr 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make test is better suited for local testing 🤔(although the tools package does not have make test now, other Makefiles all have make test)
Or do you think make test needs to be merged with make ci-test-job as the same command?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

support make test and make ci-test-job currently

@HuSharp
Copy link
Member Author

HuSharp commented Apr 7, 2024

image can increase 1.23%

@HuSharp HuSharp requested review from JmPotato and lhy1024 April 7, 2024 03:31
@HuSharp HuSharp changed the title scripts: fix client cover profile scripts: fix client and tools cover profile Apr 7, 2024
@HuSharp HuSharp requested a review from nolouch April 7, 2024 03:45
Signed-off-by: husharp <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 7, 2024
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

client/Makefile Outdated Show resolved Hide resolved
Signed-off-by: husharp <[email protected]>
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 8, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 9, 2024
@HuSharp
Copy link
Member Author

HuSharp commented Apr 9, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Apr 9, 2024

@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Apr 9, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 3b242a4

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 9, 2024
@ti-chi-bot ti-chi-bot bot merged commit ad3387c into tikv:master Apr 9, 2024
22 checks passed
@HuSharp HuSharp deleted the fix_client_cov branch April 9, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants