-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scripts: fix client and tools cover profile #8020
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Skipping CI for Draft Pull Request. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8020 +/- ##
==========================================
+ Coverage 73.58% 74.92% +1.33%
==========================================
Files 436 467 +31
Lines 48568 52406 +3838
==========================================
+ Hits 35737 39263 +3526
+ Misses 9764 9696 -68
- Partials 3067 3447 +380
Flags with carried forward coverage won't be shown. Click here to find out more. |
79c751d
to
2552b6e
Compare
b81052f
to
9dff6c5
Compare
Signed-off-by: husharp <[email protected]>
ci-test-job: failpoint-enable | ||
CGO_ENABLED=1 go test ./... -v -tags deadlock -race -cover || { $(MAKE) failpoint-disable && exit 1; } | ||
$(MAKE) failpoint-disable | ||
ci-test-job: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to enable failpoint in this command, ci-test-job
will turn on failpoint at the beginning.
Lines 248 to 251 in 6822137
ci-test-job: install-tools dashboard-ui | |
@$(FAILPOINT_ENABLE) | |
./scripts/ci-subtask.sh $(JOB_COUNT) $(JOB_INDEX) || { $(FAILPOINT_DISABLE); exit 1; } | |
@$(FAILPOINT_DISABLE) |
Disabling useless commands here will reduce some of ci time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before we can run make ci-test-job
in client package independently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe make test
is better suited for local testing 🤔(although the tools package does not have )make test
now, other Makefiles all have make test
Or do you think make test
needs to be merged with make ci-test-job
as the same command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
support make test
and make ci-test-job
currently
Signed-off-by: husharp <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
Signed-off-by: husharp <[email protected]>
Signed-off-by: husharp <[email protected]>
/merge |
@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 3b242a4
|
What problem does this PR solve?
Issue Number: Ref #4399
What is changed and how does it work?
Check List
Tests
Release note