*: fix TestMembers
#8039
*: fix TestMembers
#8039
Conversation
Signed-off-by: Ryan Leung <[email protected]>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
bot
added
the
release-note-none
ti-chi-bot
bot
added
the
size/XS
| @@ -68,7 +68,7 @@ func (s *testResourceManagerSuite) TestConfigController() { | |||
|
|
|||
| actualCfg := server.ControllerConfig{} | |||
| err = json.Unmarshal(output, &actualCfg) | |||
| re.NoError(err) | |||
| re.NoError(err, string(output)) | |||
There was a problem hiding this comment.
There is another flaky test: #8035, I cannot reproduce it in my local environment.
ti-chi-bot
bot
added
status/LGT2
|
/merge |
|
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: a94430f
|
ti-chi-bot
bot
added
the
status/can-merge
|
@rleungx: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: Close #7881.
What is changed and how does it work?
If the cluster is not started normally, the client might be nil, which will cause panic.
Check List
Tests
Release note