-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: transitioning action version from node 16 to node 20 #8071
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,21 +8,11 @@ jobs: | |
runs-on: ubuntu-latest | ||
timeout-minutes: 20 | ||
steps: | ||
- uses: actions/setup-go@v3 | ||
with: | ||
go-version: '1.21' | ||
- name: Checkout code | ||
uses: actions/checkout@v3 | ||
- name: Restore cache | ||
uses: actions/cache@v3 | ||
uses: actions/checkout@v4 | ||
- uses: actions/setup-go@v5 | ||
with: | ||
path: | | ||
~/go/pkg/mod | ||
~/.cache/go-build | ||
**/.dashboard_download_cache | ||
key: ${{ runner.os }}-golang-${{ hashFiles('**/go.sum') }} | ||
restore-keys: | | ||
${{ runner.os }}-golang | ||
Comment on lines
-17
to
-25
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. removed because have cached in setup actions/cache#1104 (comment) |
||
go-version: '1.21' | ||
- name: Make Check | ||
run: | | ||
SWAGGER=1 make build | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,20 +29,11 @@ jobs: | |
outputs: | ||
job-total: 13 | ||
steps: | ||
- uses: actions/setup-go@v3 | ||
with: | ||
go-version: '1.21' | ||
- name: Checkout code | ||
uses: actions/checkout@v3 | ||
- name: Restore cache | ||
uses: actions/cache@v3 | ||
uses: actions/checkout@v4 | ||
- uses: actions/setup-go@v5 | ||
with: | ||
path: | | ||
~/go/pkg/mod | ||
~/.cache/go-build | ||
**/.tools | ||
**/.dashboard_download_cache | ||
key: ${{ runner.os }}-go-${{ matrix.worker_id }}-${{ hashFiles('**/go.sum') }} | ||
Comment on lines
-40
to
-45
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. removed because have cached in setup actions/cache#1104 (comment) |
||
go-version: '1.21' | ||
- name: Make Test | ||
env: | ||
WORKER_ID: ${{ matrix.worker_id }} | ||
|
@@ -53,20 +44,21 @@ jobs: | |
mv covprofile covprofile_$WORKER_ID | ||
sed -i "/failpoint_binding/d" covprofile_$WORKER_ID | ||
- name: Upload coverage result ${{ matrix.worker_id }} | ||
uses: actions/upload-artifact@v2 | ||
uses: actions/upload-artifact@v4 | ||
with: | ||
name: cover-reports | ||
name: cover-reports-${{ matrix.worker_id }} | ||
path: covprofile_${{ matrix.worker_id }} | ||
report-coverage: | ||
needs: chunks | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v3 | ||
uses: actions/checkout@v4 | ||
- name: Download chunk report | ||
uses: actions/download-artifact@v2 | ||
uses: actions/download-artifact@v4 | ||
with: | ||
name: cover-reports | ||
pattern: cover-reports-* | ||
merge-multiple: true | ||
Comment on lines
+60
to
+61
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
- name: Merge | ||
env: | ||
TOTAL_JOBS: ${{needs.chunks.outputs.job-total}} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change the
checkout
andsetup
place because actions/setup-node#624 (comment)