-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator: make additional information thread safe #8104
Conversation
Signed-off-by: husharp <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8104 +/- ##
==========================================
+ Coverage 77.28% 77.30% +0.01%
==========================================
Files 470 470
Lines 61129 61143 +14
==========================================
+ Hits 47244 47264 +20
+ Misses 10310 10309 -1
+ Partials 3575 3570 -5
Flags with carried forward coverage won't be shown. Click here to find out more. |
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 6a9906b
|
/run-cherry-picker |
In response to a cherrypick label: new pull request created to branch |
close #8079 Signed-off-by: husharp <[email protected]> Co-authored-by: husharp <[email protected]>
close tikv#8079 Signed-off-by: husharp <[email protected]>
What problem does this PR solve?
Issue Number: Close #8079
What is changed and how does it work?
before #8032 merged(affected 8.1.0), controller has a lock https://github.com/tikv/pd/pull/8032/files#diff-0962f2eb6ba371d4f7abb601fdd9391aec93e770f1b75cad36045f86dea9b7d2L57
when cancel the operator, will hold this lock to avoid data race.
createOperator
panic get from the array while inserting elements in this array
Check List
Tests
Release note