Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: update grafana template to add heartbeat latency overview #8209

Merged
merged 1 commit into from
May 22, 2024

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented May 22, 2024

What problem does this PR solve?

Issue Number: Ref #7897

What is changed and how does it work?

metrics: update grafana template to add heartbeat latency overview

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    image

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented May 22, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 22, 2024
@ti-chi-bot ti-chi-bot bot requested review from HuSharp and lhy1024 May 22, 2024 06:40
@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 22, 2024
@nolouch nolouch requested review from JmPotato and rleungx and removed request for lhy1024 and HuSharp May 22, 2024 06:41
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.32%. Comparing base (d7c7a41) to head (53ed412).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8209      +/-   ##
==========================================
+ Coverage   77.26%   77.32%   +0.06%     
==========================================
  Files         471      471              
  Lines       61425    61425              
==========================================
+ Hits        47459    47498      +39     
+ Misses      10398    10364      -34     
+ Partials     3568     3563       -5     
Flag Coverage Δ
unittests 77.32% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 22, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 22, 2024
@nolouch
Copy link
Contributor Author

nolouch commented May 22, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented May 22, 2024

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented May 22, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 53ed412

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 22, 2024
@ti-chi-bot ti-chi-bot bot merged commit b871b57 into tikv:master May 22, 2024
19 checks passed
@nolouch nolouch deleted the update-metrics branch May 22, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants