Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: fix the duplicate avg metrics #8210

Merged
merged 2 commits into from
May 23, 2024
Merged

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented May 22, 2024

What problem does this PR solve?

Issue Number: ref #7897

What is changed and how does it work?

metrics: fix the duplicate avg metrics

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    before
    image

after
image

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented May 22, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • JmPotato

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 22, 2024
@ti-chi-bot ti-chi-bot bot requested review from JmPotato and rleungx May 22, 2024 11:36
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 22, 2024
@nolouch nolouch changed the title metrics: fix the duplicate avg metrics: fix the duplicate avg metrics May 22, 2024
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.27%. Comparing base (0f3e1f9) to head (447dd42).

Current head 447dd42 differs from pull request most recent head 13ad370

Please upload reports for the commit 13ad370 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8210      +/-   ##
==========================================
- Coverage   77.29%   77.27%   -0.03%     
==========================================
  Files         471      471              
  Lines       61436    61436              
==========================================
- Hits        47490    47476      -14     
- Misses      10369    10398      +29     
+ Partials     3577     3562      -15     
Flag Coverage Δ
unittests 77.27% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 23, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 23, 2024
@JmPotato
Copy link
Member

/merge

Copy link
Contributor

ti-chi-bot bot commented May 23, 2024

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented May 23, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 447dd42

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 23, 2024
Copy link
Contributor

ti-chi-bot bot commented May 23, 2024

@nolouch: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 6b8d227 into tikv:master May 23, 2024
15 checks passed
okJiang pushed a commit to okJiang/pd that referenced this pull request May 23, 2024
ref tikv#7897

metrics: fix the duplicate avg metrics

Signed-off-by: nolouch <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: okJiang <[email protected]>
okJiang pushed a commit to okJiang/pd that referenced this pull request May 23, 2024
ref tikv#7897

metrics: fix the duplicate avg metrics

Signed-off-by: nolouch <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: okJiang <[email protected]>
@nolouch nolouch deleted the fix-templ branch May 23, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants