Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rc: fix group change will meet data race #8268

Merged
merged 3 commits into from
Jun 11, 2024
Merged

rc: fix group change will meet data race #8268

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ea5d78
fix data race
HuSharp Jun 6, 2024
b5a4f5c
Merge branch 'master' into fix_rc_data_race
HuSharp Jun 7, 2024
0b7d0b9
Merge branch 'master' into fix_rc_data_race
ti-chi-bot[bot] Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/mcs/resourcemanager/server/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,9 @@ func (m *Manager) Init(ctx context.Context) error {
return err
}
// Load resource group meta info from storage.
m.Lock()
Copy link
Contributor

@lhy1024 lhy1024 Jun 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need to be picked to other branches?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so

m.groups = make(map[string]*ResourceGroup)
m.Unlock()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where will it be called concurrently?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think because there is no happens-before guarantee for different goroutines, maybe meet memory reordering.

handler := func(k, v string) {
group := &rmpb.ResourceGroup{}
if err := proto.Unmarshal([]byte(v), group); err != nil {
Expand Down