Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rc: fix group change will meet data race (#8268) #8294

Merged
merged 1 commit into from
Jun 17, 2024
Merged

rc: fix group change will meet data race (#8268) #8294

merged 1 commit into from
Jun 17, 2024

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8268

What problem does this PR solve?

Issue Number: Close #8267

What is changed and how does it work?

Because there is no happens-before guarantee for different goroutine, maybe meet memory reordering

Check List

Tests

  • No code(Cannot test it for memory ordering :( )

Release note

None.

@HuSharp @ti-chi-bot
fix data race
a441c1c 
Signed-off-by: husharp <[email protected]>
@ti-chi-bot ti-chi-bot added approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Jun 17, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 17, 2024
Merged
@ti-chi-bot ti-chi-bot bot removed the approved label Jun 17, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 17, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 17, 2024
@ti-chi-bot ti-chi-bot bot merged commit 22c5c9e into tikv:release-7.1 Jun 17, 2024
18 of 19 checks passed
@HuSharp HuSharp deleted the cherry-pick-8268-to-release-7.1 branch June 17, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HuSharp HuSharp HuSharp approved these changes

Assignees

@HuSharp HuSharp

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ti-chi-bot @HuSharp