Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: fix the panic caused by zero RegionSplitSizeMB (#8324) #8328

Merged
merged 2 commits into from
Jun 26, 2024
Merged

config: fix the panic caused by zero RegionSplitSizeMB (#8324) #8328

merged 2 commits into from
Jun 26, 2024

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8324

What problem does this PR solve?

Issue Number: close #8323.

What is changed and how does it work?

Bypass the case that `RegionSplitSizeMB` might be zero in `(*StoreConfig) CheckRegionSize`.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 25, 2024
Merged
@ti-chi-bot ti-chi-bot added approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Jun 25, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 25, 2024
@JmPotato
Resolve the conflicts
573d2a8 
Signed-off-by: JmPotato <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 25, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 25, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, niubell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 26, 2024
@ti-chi-bot ti-chi-bot bot merged commit 50c70af into tikv:release-7.1 Jun 26, 2024
17 of 18 checks passed
@JmPotato JmPotato deleted the cherry-pick-8324-to-release-7.1 branch June 26, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niubell niubell niubell approved these changes

@JmPotato JmPotato JmPotato approved these changes

Assignees

@JmPotato JmPotato

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @JmPotato @niubell