client: make TSO client request duration include failed requests #8410
Conversation
Signed-off-by: JmPotato <[email protected]>
ti-chi-bot
bot
added
release-note-none
|
/test build |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8410 +/- ##
==========================================
- Coverage 77.21% 77.20% -0.01%
==========================================
Files 471 471
Lines 61835 61840 +5
==========================================
- Hits 47747 47745 -2
- Misses 10499 10501 +2
- Partials 3589 3594 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
client/tso_stream.go
Outdated
| @@ -141,6 +141,7 @@ func (s *pdTSOStream) processRequests( | |||
| } | |||
| tsoBatchSendLatency.Observe(time.Since(batchStartTime).Seconds()) | |||
| resp, err := s.stream.Recv() | |||
| requestDurationTSO.Observe(time.Since(start).Seconds()) | |||
There was a problem hiding this comment.
Do we need to distinguish them?
There was a problem hiding this comment.
Do you mean to distinguish the duration between success and failure? Currently, I don't think it's necessary because we generally only use this metric to compare TSO Wait Duration to infer the source of the delay, the latter does not distinguish between successful and failed requests.
There was a problem hiding this comment.
Yes, I was wondering if we find a latency spike, we might need to know if the request has succeeded or failed.
There was a problem hiding this comment.
Make sense. Addressed. PTAL.
Signed-off-by: JmPotato <[email protected]>
ti-chi-bot
bot
added
size/S
| cmdFailedDurationGet = cmdFailedDuration.WithLabelValues("get") | ||
| cmdFailedDurationPut = cmdFailedDuration.WithLabelValues("put") | ||
| cmdFailedDurationUpdateGCSafePointV2 = cmdFailedDuration.WithLabelValues("update_gc_safe_point_v2") | ||
| cmdFailedDurationUpdateServiceSafePointV2 = cmdFailedDuration.WithLabelValues("update_service_safe_point_v2") | ||
|
|
||
| requestDurationTSO = requestDuration.WithLabelValues("tso") | ||
| requestFailedDurationTSO = requestDuration.WithLabelValues("tso-failed") |
There was a problem hiding this comment.
Do we need underline?
| requestFailedDurationTSO = requestDuration.WithLabelValues("tso-failed") | |
| requestFailedDurationTSO = requestDuration.WithLabelValues("tso_failed") |
ti-chi-bot
bot
added
needs-1-more-lgtm
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HuSharp, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
ti-chi-bot
bot
added
the
do-not-merge/hold
|
/unhold |
ti-chi-bot
bot
removed
the
do-not-merge/hold
What problem does this PR solve?
Issue Number: ref #8281.
What is changed and how does it work?
Check List
Tests
Release note