-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: add frequency check time to make resign test more stable #8411
Conversation
Signed-off-by: husharp <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8411 +/- ##
=======================================
Coverage 77.31% 77.32%
=======================================
Files 471 471
Lines 61878 61882 +4
=======================================
+ Hits 47840 47849 +9
+ Misses 10466 10457 -9
- Partials 3572 3576 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pkg/member/member.go
Outdated
|
||
// ChangeFrequencyTimes changes the frequency check times of campaign leader. | ||
// ONLY used for test to make the test more stable. | ||
// PLEASE flash back this value after using. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about using failpoint here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed
Signed-off-by: husharp <[email protected]>
39c9cf2
to
392ae60
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JmPotato, lhy1024, okJiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
tests: add frequency check time to make resign test more stable
Conclude: Because frequently change(There are many resign leader in this test and slow disk can make frequently happened in high probability :(
cluster_test.go:262
checks pd leader not bepd3
, which meanscluster.ResignLeader()
regards pd3 is leader, buttc.WaitLeader()
still get pd3Let's check the log:
Issue Number: Close #8319, #8351
What is changed and how does it work?
Check List
Tests
Release note