Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resourcemanager: make TestResourceManagerServer more stable #8418

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Jul 18, 2024

What problem does this PR solve?

Issue Number: Close #8417

What is changed and how does it work?

2024-07-18T08:30:29.5157887Z --- FAIL: TestResourceManagerServer (2.97s)
2024-07-18T08:30:29.5158616Z     server_test.go:62: 
2024-07-18T08:30:29.5160011Z         	Error Trace:	/home/runner/work/pd/pd/tests/integrations/mcs/resourcemanager/server_test.go:62
2024-07-18T08:30:29.5162038Z         	Error:      	Error "rpc error: code = Unavailable desc = not leader" does not contain "resource group not found"
2024-07-18T08:30:29.5163328Z         	Test:       	TestResourceManagerServer
2024-07-18T08:30:29.5163912Z FAIL

checked by

func (s *Service) checkServing() error {
if s.manager == nil || s.manager.srv == nil || !s.manager.srv.IsServing() {
return errNotLeader
}
return nil
}

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: husharp <[email protected]>
@HuSharp HuSharp requested a review from JmPotato July 18, 2024 09:00
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. labels Jul 18, 2024
@HuSharp HuSharp changed the title resourcemanager: make TestResourceManagerServer more unstable resourcemanager: make TestResourceManagerServer more stable Jul 18, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 18, 2024
@HuSharp HuSharp requested a review from lhy1024 July 18, 2024 09:02
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.22%. Comparing base (c65577c) to head (1e0f9e4).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8418      +/-   ##
==========================================
- Coverage   77.28%   77.22%   -0.07%     
==========================================
  Files         471      471              
  Lines       61878    61878              
==========================================
- Hits        47823    47783      -40     
- Misses      10470    10501      +31     
- Partials     3585     3594       +9     
Flag Coverage Δ
unittests 77.22% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

ti-chi-bot bot commented Jul 19, 2024

@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

ti-chi-bot bot commented Jul 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, nolouch, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 19, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-18 09:05:42.951378486 +0000 UTC m=+517564.942319951: ☑️ agreed by lhy1024.
  • 2024-07-19 06:54:25.428816468 +0000 UTC m=+596087.419757934: ☑️ agreed by nolouch.

@ti-chi-bot ti-chi-bot bot merged commit c514937 into tikv:master Jul 19, 2024
20 of 21 checks passed
@HuSharp HuSharp deleted the fix_primary_ready branch July 19, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestResourceManagerServer is unstable
4 participants