Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/ut: add -v to help diagnose #8421

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Jul 19, 2024

What problem does this PR solve?

before, The error message will appear at the very end
image
We'd prefer to have the error message appear immediately so that it's easy to know the event clearly.

Issue Number: Ref #7969

What is changed and how does it work?

When meet error in the test, let the error message appear immediately so that it's easy to know the event clearly.
image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

None.

Signed-off-by: husharp <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 19, 2024
@HuSharp HuSharp requested review from lhy1024 and rleungx July 19, 2024 04:03
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 19, 2024
Signed-off-by: husharp <[email protected]>
Copy link
Contributor

ti-chi-bot bot commented Jul 19, 2024

@HuSharp: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-integration-realcluster-test 9e61091 link false /test pull-integration-realcluster-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.29%. Comparing base (c65577c) to head (9e61091).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8421   +/-   ##
=======================================
  Coverage   77.28%   77.29%           
=======================================
  Files         471      471           
  Lines       61878    61878           
=======================================
+ Hits        47823    47828    +5     
+ Misses      10470    10467    -3     
+ Partials     3585     3583    -2     
Flag Coverage Δ
unittests 77.29% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@HuSharp HuSharp changed the title tools/ut: add -v to test tools/ut: add -v to help diagnose Jul 19, 2024
@HuSharp HuSharp requested a review from JmPotato July 19, 2024 05:10
Copy link
Contributor

ti-chi-bot bot commented Jul 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 19, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-19 04:04:05.321300754 +0000 UTC m=+585867.312242225: ☑️ agreed by lhy1024.
  • 2024-07-19 05:22:39.229581853 +0000 UTC m=+590581.220523321: ☑️ agreed by rleungx.

@ti-chi-bot ti-chi-bot bot merged commit 1c86ddb into tikv:master Jul 19, 2024
24 of 25 checks passed
@HuSharp HuSharp deleted the add_diagnose_to_ut branch July 19, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants