Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: upgrade go-graphviz #8423

Merged
merged 1 commit into from
Jul 19, 2024
Merged

*: upgrade go-graphviz #8423

merged 1 commit into from
Jul 19, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jul 19, 2024

What problem does this PR solve?

Issue Number: Close #8422.

What is changed and how does it work?

Check List

Tests

  • Manual test

Release note

None.

Signed-off-by: Ryan Leung <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 19, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 19, 2024
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.23%. Comparing base (c514937) to head (89decdd).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8423      +/-   ##
==========================================
- Coverage   77.31%   77.23%   -0.08%     
==========================================
  Files         471      471              
  Lines       61878    61878              
==========================================
- Hits        47840    47791      -49     
- Misses      10466    10495      +29     
- Partials     3572     3592      +20     
Flag Coverage Δ
unittests 77.23% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

ti-chi-bot bot commented Jul 19, 2024

@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 19, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, nolouch, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 19, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-19 09:16:15.546493729 +0000 UTC m=+604597.537435199: ☑️ agreed by lhy1024.
  • 2024-07-19 10:03:27.814945157 +0000 UTC m=+607429.805886624: ☑️ agreed by nolouch.

@ti-chi-bot ti-chi-bot bot merged commit a17ff35 into tikv:master Jul 19, 2024
26 checks passed
@rleungx rleungx deleted the upgrade-dependency branch July 20, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build warning on OSX environment
4 participants