Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: pass context to task #8429

Merged
merged 2 commits into from
Jul 23, 2024
Merged

*: pass context to task #8429

merged 2 commits into from
Jul 23, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jul 23, 2024

What problem does this PR solve?

Issue Number: Close #8386.

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 23, 2024
@rleungx rleungx requested review from nolouch and HuSharp July 23, 2024 03:17
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 75.75758% with 8 lines in your changes missing coverage. Please review.

Project coverage is 77.22%. Comparing base (624b6f3) to head (c73c81a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8429      +/-   ##
==========================================
- Coverage   77.34%   77.22%   -0.13%     
==========================================
  Files         471      471              
  Lines       61914    61922       +8     
==========================================
- Hits        47890    47819      -71     
- Misses      10448    10522      +74     
- Partials     3576     3581       +5     
Flag Coverage Δ
unittests 77.22% <75.75%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 23, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 23, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-23 06:55:01.689842331 +0000 UTC m=+941723.680783799: ☑️ agreed by HuSharp.
  • 2024-07-23 09:15:22.520337512 +0000 UTC m=+950144.511278981: ☑️ agreed by nolouch.

Copy link
Contributor

ti-chi-bot bot commented Jul 23, 2024

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Jul 23, 2024

@rleungx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-integration-realcluster-test c73c81a link false /test pull-integration-realcluster-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rleungx
Copy link
Member Author

rleungx commented Jul 23, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit 0c56739 into tikv:master Jul 23, 2024
24 of 25 checks passed
@rleungx rleungx deleted the runner-context1 branch July 24, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data race at ConcurrentRunner
3 participants