Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: fix panic issue in tso bench #8449

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Jul 26, 2024

What problem does this PR solve?

Issue Number: Close #8448

What is changed and how does it work?

tools: fix panic issue in tso bench

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    image
    no panic

Release note

None.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 26, 2024
@nolouch nolouch requested review from lhy1024 and rleungx July 26, 2024 07:59
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 26, 2024
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.40%. Comparing base (024656b) to head (55c1f75).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8449      +/-   ##
==========================================
+ Coverage   77.31%   77.40%   +0.08%     
==========================================
  Files         472      472              
  Lines       61799    61799              
==========================================
+ Hits        47781    47836      +55     
+ Misses      10441    10393      -48     
+ Partials     3577     3570       -7     
Flag Coverage Δ
unittests 77.40% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

ti-chi-bot bot commented Jul 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 26, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-26 08:06:12.860302253 +0000 UTC m=+1205194.851243723: ☑️ agreed by lhy1024.
  • 2024-07-26 08:19:15.690070279 +0000 UTC m=+1205977.681011749: ☑️ agreed by rleungx.

@HuSharp
Copy link
Member

HuSharp commented Jul 26, 2024

/check-issue-triage-complete

Copy link
Contributor

ti-chi-bot bot commented Jul 26, 2024

@nolouch: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 11da622 into tikv:master Jul 26, 2024
24 of 25 checks passed
@nolouch nolouch deleted the fix-bench-tso branch July 29, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic during TSO benchmark run.
4 participants