Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdms: Add the name field to the startup parameters #8461

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Jul 31, 2024

What problem does this PR solve?

Issue Number: Ref #7995

What is changed and how does it work?

operator PR: pingcap/tidb-operator#5698
TiUP PR: pingcap/tiup#2447

when check members

curl --location --request GET 'http://127.0.0.1:2379/pd/api/v2/ms/members/tso'
[
    {
        "name": "tso-0",
        "service-addr": "http://127.0.0.1:58940",
        "version": "v8.3.0-alpha-6-g9af28fc1d-dirty",
        "git-hash": "9af28fc1d426697f90bba2f46b3957ec4f03bdcb",
        "deploy-path": "/Users/pingcap/CS/PingCAP/pd/bin",
        "start-timestamp": 1722396004
    },
    {
        "name": "tso-1",
        "service-addr": "http://127.0.0.1:58942",
        "version": "v8.3.0-alpha-6-g9af28fc1d-dirty",
        "git-hash": "9af28fc1d426697f90bba2f46b3957ec4f03bdcb",
        "deploy-path": "/Users/pingcap/CS/PingCAP/pd/bin",
        "start-timestamp": 1722396004
    }
]

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

PD microservices add `--name` startup parameter

Signed-off-by: husharp <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 31, 2024
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.38%. Comparing base (87ec788) to head (c7d3f8a).
Report is 29 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8461      +/-   ##
==========================================
+ Coverage   77.34%   77.38%   +0.04%     
==========================================
  Files         472      472              
  Lines       61727    61739      +12     
==========================================
+ Hits        47743    47777      +34     
+ Misses      10419    10400      -19     
+ Partials     3565     3562       -3     
Flag Coverage Δ
unittests 77.38% <94.44%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 31, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 2, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 2, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-31 05:38:51.06714125 +0000 UTC m=+334247.347189341: ☑️ agreed by rleungx.
  • 2024-08-02 06:23:48.478663572 +0000 UTC m=+70625.697425180: ☑️ agreed by lhy1024.

Copy link
Contributor

ti-chi-bot bot commented Aug 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, lhy1024, niubell, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 2, 2024
@ti-chi-bot ti-chi-bot bot merged commit 95645aa into tikv:master Aug 2, 2024
25 checks passed
@HuSharp HuSharp deleted the add_pdms_name branch August 2, 2024 08:40
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants