Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/retry: only return the latest error in backoffer (#8227) #8465

Merged

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jul 31, 2024

This is an automated cherry-pick of #8227

What problem does this PR solve?

Issue Number: close #8499, ref #8142.

What is changed and how does it work?

Due to the return of historical errors causing the client's retry logic to fail,
and since we currently do not need to obtain all errors during retries, this PR
removes `multierr` from backoffer and add tests to ensure the correctness of the retry logic.

Check List

Tests

  • Unit test
  • Integration test

Release note

Fix the bug where HTTP client retry logic is ineffective.

@ti-chi-bot ti-chi-bot added component/client Client logic. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Jul 31, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved dco-signoff: yes Indicates the PR's author has signed the dco. labels Jul 31, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 31, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 31, 2024
@JmPotato
Copy link
Member

JmPotato commented Aug 1, 2024

There's no need to cherry-pick because it's a client-side change.

@JmPotato JmPotato closed this Aug 1, 2024
@JmPotato JmPotato deleted the cherry-pick-8227-to-release-8.1 branch August 1, 2024 04:13
@JmPotato JmPotato restored the cherry-pick-8227-to-release-8.1 branch August 6, 2024 10:03
@JmPotato JmPotato reopened this Aug 6, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 6, 2024
@JmPotato JmPotato force-pushed the cherry-pick-8227-to-release-8.1 branch from c23230c to be99a3a Compare August 6, 2024 10:34
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 6, 2024
@JmPotato JmPotato force-pushed the cherry-pick-8227-to-release-8.1 branch 2 times, most recently from 5bbab09 to 7da1420 Compare August 6, 2024 10:37
@JmPotato JmPotato force-pushed the cherry-pick-8227-to-release-8.1 branch from 7da1420 to a0cc33b Compare August 6, 2024 10:45
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 6, 2024
@JmPotato JmPotato self-requested a review August 6, 2024 10:46
@JmPotato JmPotato requested a review from HuSharp August 6, 2024 10:46
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 6, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, JmPotato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 6, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-06 10:46:54.626196386 +0000 UTC m=+348944.493295471: ☑️ agreed by JmPotato.
  • 2024-08-06 10:50:20.686256766 +0000 UTC m=+349150.553355854: ☑️ agreed by HuSharp.

@ti-chi-bot ti-chi-bot bot merged commit 10ecdbe into tikv:release-8.1 Aug 6, 2024
21 checks passed
@JmPotato JmPotato deleted the cherry-pick-8227-to-release-8.1 branch August 6, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. component/client Client logic. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants