-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: instead scheduler type string of types.CheckerSchedulerType #8485
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
ede4112
save work
okJiang d48eaa0
fix static
okJiang 915e6ba
remove type
okJiang fdd8821
Merge branch 'master' of github.com:tikv/pd into name5
okJiang 1f20ae6
fix lint
okJiang 3ada3f5
fix ci
okJiang 912cde3
rename variable
okJiang 95fc46b
fix unit test
okJiang 43a5eb1
Merge branch 'master' into name5
okJiang d227f56
remove duplicate
okJiang 87acf7f
Merge branch 'name5' of github.com:okJiang/pd into name5
okJiang f91836a
add some comment
okJiang 7d38383
fix comment
okJiang 25f5f1a
Merge branch 'master' into name5
okJiang bdb4d19
fix comment: rename
okJiang afc4fbe
Merge branch 'master' of https://github.com/tikv/pd into name5
okJiang f9362a0
Merge branch 'master' of https://github.com/tikv/pd into name5
okJiang ebcc655
trigger ci
okJiang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,8 +43,6 @@ import ( | |
const ( | ||
// BalanceLeaderName is balance leader scheduler name. | ||
BalanceLeaderName = "balance-leader-scheduler" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we will unify it? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It will be in the next pr |
||
// BalanceLeaderType is balance leader scheduler type. | ||
BalanceLeaderType = "balance-leader" | ||
// BalanceLeaderBatchSize is the default number of operators to transfer leaders by one scheduling. | ||
// Default value is 4 which is subjected by scheduler-max-waiting-operator and leader-schedule-limit | ||
// If you want to increase balance speed more, please increase above-mentioned param. | ||
|
@@ -536,7 +534,7 @@ func (l *balanceLeaderScheduler) createOperator(solver *solver, collector *plan. | |
} | ||
solver.Step++ | ||
defer func() { solver.Step-- }() | ||
op, err := operator.CreateTransferLeaderOperator(BalanceLeaderType, solver, solver.Region, solver.targetStoreID(), []uint64{}, operator.OpLeader) | ||
op, err := operator.CreateTransferLeaderOperator(l.GetName(), solver, solver.Region, solver.targetStoreID(), []uint64{}, operator.OpLeader) | ||
if err != nil { | ||
log.Debug("fail to create balance leader operator", errs.ZapError(err)) | ||
if collector != nil { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about renaming to
ConvertNewType2OldStr