Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client/http: fix the URI of GetRegionLabelRulesByIDs (#8490) #8493

Merged
merged 2 commits into from
Aug 5, 2024
Merged

client/http: fix the URI of GetRegionLabelRulesByIDs (#8490) #8493

merged 2 commits into from
Aug 5, 2024

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8490

What problem does this PR solve?

Issue Number: close #8491, ref pingcap/tidb#55188.

What is changed and how does it work?

Fix the URI of `GetRegionLabelRulesByIDs` to correct the call.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@ti-chi-bot ti-chi-bot added approved component/client Client logic. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Aug 5, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 5, 2024
Merged
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed approved size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 5, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 5, 2024
@ti-chi-bot ti-chi-bot bot added the approved label Aug 5, 2024
@JmPotato
Resolve the conflicts
9f100ce 
Signed-off-by: JmPotato <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 5, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 3d11c4d into tikv:release-8.1 Aug 5, 2024
21 checks passed
@JmPotato JmPotato deleted the cherry-pick-8490-to-release-8.1 branch August 5, 2024 09:45
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Aug 5, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

@JmPotato JmPotato JmPotato approved these changes

Assignees

@JmPotato JmPotato

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. component/client Client logic. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @JmPotato @rleungx