Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: skip the engine key when match store label (#8486) #8574

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8486

What problem does this PR solve?

Issue Number: Close #8480.

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot added the dco-signoff: yes Indicates the PR's author has signed the dco. label Aug 27, 2024
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. labels Aug 27, 2024
@rleungx rleungx force-pushed the cherry-pick-8486-to-release-5.4 branch from dc04cf5 to ea2454c Compare August 27, 2024 08:44
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 27, 2024
@rleungx rleungx force-pushed the cherry-pick-8486-to-release-5.4 branch 2 times, most recently from 246173d to bd07e2d Compare August 27, 2024 09:00
Signed-off-by: Ryan Leung <[email protected]>
@rleungx rleungx force-pushed the cherry-pick-8486-to-release-5.4 branch from bd07e2d to a2ed10c Compare August 27, 2024 09:09
Copy link
Contributor

ti-chi-bot bot commented Aug 27, 2024

@HuSharp: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

ti-chi-bot bot commented Aug 28, 2024

@lhy1024: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rleungx rleungx force-pushed the cherry-pick-8486-to-release-5.4 branch from aea0621 to a2ed10c Compare September 9, 2024 08:23
@wuhuizuo
Copy link
Contributor

wuhuizuo commented Sep 9, 2024

Please send /lgtm or /approve again when #8606 is merged.

@ti-chi-bot ti-chi-bot bot added the approved label Sep 9, 2024
@rleungx
Copy link
Member

rleungx commented Sep 9, 2024

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 9, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 10, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-09 09:01:15.890862628 +0000 UTC m=+260545.631286567: ☑️ agreed by rleungx.
  • 2024-09-10 07:20:53.467918159 +0000 UTC m=+340923.208342098: ☑️ agreed by lhy1024.

Copy link
Contributor

ti-chi-bot bot commented Sep 11, 2024

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Sep 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, lhy1024, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [HuSharp,lhy1024,rleungx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit a8ea617 into tikv:release-5.4 Sep 11, 2024
12 checks passed
@HuSharp HuSharp deleted the cherry-pick-8486-to-release-5.4 branch September 11, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants