*: make TestForwardTSOUnexpectedToFollower stable
#8595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Leung <[email protected]>
ti-chi-bot
bot
added
release-note-none
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8595 +/- ##
==========================================
- Coverage 77.61% 77.55% -0.07%
==========================================
Files 474 474
Lines 61852 61852
==========================================
- Hits 48006 47967 -39
- Misses 10316 10335 +19
- Partials 3530 3550 +20
Flags with carried forward coverage won't be shown. Click here to find out more. |
lhy1024
reviewed
Sep 5, 2024
| @@ -57,7 +57,7 @@ import ( | |||
|
|
|||
| const ( | |||
| heartbeatSendTimeout = 5 * time.Second | |||
| maxRetryTimesRequestTSOServer = 3 | |||
| maxRetryTimesRequestTSOServer = 6 | |||
There was a problem hiding this comment.
Perhaps we need a better mechanism later.
HuSharp
approved these changes
Sep 5, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
lhy1024
approved these changes
Sep 6, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HuSharp, lhy1024 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: Close #8589, close #8397.
What is changed and how does it work?
Increase the retry times to make sure that force load should happen at least once.
Check List
Tests
Release note