Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: move key_path.go #8596

Merged
merged 4 commits into from
Sep 10, 2024
Merged

*: move key_path.go #8596

merged 4 commits into from
Sep 10, 2024

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Sep 4, 2024

What problem does this PR solve?

The place that access the keypath is not required to import endpoint.

Issue Number: Ref #4399

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

Signed-off-by: okJiang <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 4, 2024
Signed-off-by: okJiang <[email protected]>
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 94.33962% with 9 lines in your changes missing coverage. Please review.

Project coverage is 77.56%. Comparing base (b5c4a58) to head (41ff779).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8596      +/-   ##
==========================================
- Coverage   77.59%   77.56%   -0.04%     
==========================================
  Files         474      474              
  Lines       61891    61891              
==========================================
- Hits        48023    48003      -20     
- Misses      10327    10337      +10     
- Partials     3541     3551      +10     
Flag Coverage Δ
unittests 77.56% <94.33%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@lhy1024
Copy link
Contributor

lhy1024 commented Sep 4, 2024

Maybe we will replace etcd with other backend, I don't think it is a good idea to move keypath to etcdutil.

@okJiang
Copy link
Member Author

okJiang commented Sep 4, 2024

Maybe we will replace etcd with other backend, I don't think it is a good idea to move keypath to etcdutil.

Do you have any better suggestion? In current situation, I think it is ok to move into etcdutil.

@okJiang
Copy link
Member Author

okJiang commented Sep 4, 2024

Maybe we will replace etcd with other backend, I don't think it is a good idea to move keypath to etcdutil.

Do you have any better suggestion? In current situation, I think it is ok to move into etcdutil.

How about utils/keypath?

@okJiang
Copy link
Member Author

okJiang commented Sep 9, 2024

/cc @lhy1024 @rleungx @JmPotato

Copy link
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think utils/keypath might be better, and see what others suggest.

@okJiang
Copy link
Member Author

okJiang commented Sep 10, 2024

I think utils/keypath might be better, and see what others suggest.

What do you think? @rleungx @JmPotato

@rleungx
Copy link
Member

rleungx commented Sep 10, 2024

utils/keypath LGTM

Signed-off-by: okJiang <[email protected]>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 10, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 10, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-10 06:14:13.39809467 +0000 UTC m=+336923.138518610: ☑️ agreed by rleungx.
  • 2024-09-10 07:20:25.952494108 +0000 UTC m=+340895.692918048: ☑️ agreed by JmPotato.

Copy link
Contributor

ti-chi-bot bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, lhy1024, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JmPotato,lhy1024,rleungx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit b95ddda into tikv:master Sep 10, 2024
25 checks passed
@okJiang okJiang deleted the move-key-path branch September 10, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants