-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: move key_path.go #8596
*: move key_path.go #8596
Conversation
Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8596 +/- ##
==========================================
- Coverage 77.59% 77.56% -0.04%
==========================================
Files 474 474
Lines 61891 61891
==========================================
- Hits 48023 48003 -20
- Misses 10327 10337 +10
- Partials 3541 3551 +10
Flags with carried forward coverage won't be shown. Click here to find out more. |
Maybe we will replace etcd with other backend, I don't think it is a good idea to move keypath to etcdutil. |
Do you have any better suggestion? In current situation, I think it is ok to move into etcdutil. |
How about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think utils/keypath might be better, and see what others suggest.
utils/keypath LGTM |
Signed-off-by: okJiang <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JmPotato, lhy1024, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
The place that access the keypath is not required to import endpoint.
Issue Number: Ref #4399
What is changed and how does it work?
Check List
Tests
Release note