Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: transitioning action version from node 16 to node 20 (#8071) #8626

Merged

Conversation

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Sep 13, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved dco-signoff: yes Indicates the PR's author has signed the dco. cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 13, 2024
Signed-off-by: husharp <[email protected]>
@HuSharp HuSharp force-pushed the cherry-pick-8071-to-release-7.1 branch from 2d105da to 49e0313 Compare September 14, 2024 02:37
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 14, 2024
@wuhuizuo
Copy link
Contributor

/unlabel ?

@wuhuizuo
Copy link
Contributor

/remove-label ?

Copy link
Contributor

ti-chi-bot bot commented Sep 14, 2024

@wuhuizuo: The label(s) ? cannot be applied. These labels are supported: Hacktoberfest, challenge-program, ci-unstable, compatibility-breaker, high-performance, hptc, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.1, needs-cherry-pick-release-6.5, needs-cherry-pick-release-7.1, needs-cherry-pick-release-7.5, needs-cherry-pick-release-8.1, needs-cherry-pick-release-8.3, release-note, require-LGT1, wontfix, affects-5.4, affects-6.1, affects-6.5, affects-7.1, affects-7.5, affects-8.1, affects-8.3, may-affects-5.4, may-affects-6.1, may-affects-6.5, may-affects-7.1, may-affects-7.5, may-affects-8.1.

In response to this:

/remove-label ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot removed type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Sep 14, 2024
Copy link

codecov bot commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.79%. Comparing base (002b454) to head (49e0313).
Report is 2 commits behind head on release-7.1.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-7.1    #8626      +/-   ##
===============================================
- Coverage        74.82%   74.79%   -0.04%     
===============================================
  Files              412      412              
  Lines            41922    41923       +1     
===============================================
- Hits             31370    31357      -13     
- Misses            7796     7817      +21     
+ Partials          2756     2749       -7     
Flag Coverage Δ
unittests 74.79% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 14, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nolouch, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 14, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-14 02:45:41.570686547 +0000 UTC m=+670011.311110483: ☑️ agreed by rleungx.
  • 2024-09-14 03:01:39.052692614 +0000 UTC m=+670968.793116553: ☑️ agreed by nolouch.

@ti-chi-bot ti-chi-bot bot merged commit 34f401d into tikv:release-7.1 Sep 14, 2024
20 checks passed
@HuSharp HuSharp deleted the cherry-pick-8071-to-release-7.1 branch September 25, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants