-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: transitioning action version from node 16 to node 20 (#8071) #8628
Merged
ti-chi-bot
merged 1 commit into
tikv:release-6.5
from
ti-chi-bot:cherry-pick-8071-to-release-6.5
Sep 20, 2024
Merged
ci: transitioning action version from node 16 to node 20 (#8071) #8628
ti-chi-bot
merged 1 commit into
tikv:release-6.5
from
ti-chi-bot:cherry-pick-8071-to-release-6.5
Sep 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
added
release-note-none
Denotes a PR that doesn't merit a release note.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
type/cherry-pick-for-release-5.4
This PR is cherry-picked to release-5.4 from a source PR.
type/cherry-pick-for-release-6.1
This PR is cherry-picked to release-6.1 from a source PR.
type/cherry-pick-for-release-6.5
This PR is cherry-picked to release-6.5 from a source PR.
labels
Sep 13, 2024
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
dco-signoff: yes
Indicates the PR's author has signed the dco.
labels
Sep 13, 2024
Signed-off-by: husharp <[email protected]>
HuSharp
force-pushed
the
cherry-pick-8071-to-release-6.5
branch
from
September 14, 2024 02:35
4fe32af
to
7e08655
Compare
rleungx
approved these changes
Sep 14, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
Indicates a PR needs 1 more LGTM.
approved
labels
Sep 14, 2024
nolouch
approved these changes
Sep 14, 2024
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Indicates a PR needs 1 more LGTM.
labels
Sep 14, 2024
rleungx
removed
type/cherry-pick-for-release-5.4
This PR is cherry-picked to release-5.4 from a source PR.
type/cherry-pick-for-release-6.1
This PR is cherry-picked to release-6.1 from a source PR.
labels
Sep 14, 2024
bufferflies
approved these changes
Sep 16, 2024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bufferflies, nolouch, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
cherry-pick-approved
Cherry pick PR approved by release team.
and removed
do-not-merge/cherry-pick-not-approved
labels
Sep 20, 2024
lhy1024
pushed a commit
to lhy1024/pd
that referenced
this pull request
Nov 4, 2024
…ikv#8628) close tikv#8070 Signed-off-by: husharp <[email protected]> Co-authored-by: husharp <[email protected]>
lhy1024
pushed a commit
to lhy1024/pd
that referenced
this pull request
Nov 5, 2024
…ikv#8628) close tikv#8070 Signed-off-by: husharp <[email protected]> Co-authored-by: husharp <[email protected]> Signed-off-by: lhy1024 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
cherry-pick-approved
Cherry pick PR approved by release team.
dco-signoff: yes
Indicates the PR's author has signed the dco.
lgtm
release-note-none
Denotes a PR that doesn't merit a release note.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
type/cherry-pick-for-release-6.5
This PR is cherry-picked to release-6.5 from a source PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #8071
What problem does this PR solve?
Issue Number: Close #8070
What is changed and how does it work?
problems
https://github.com/tikv/pd/actions/runs/8699677331?pr=8072
https://github.com/tikv/pd/pull/8072/checks
solution
rely on
https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/
action release note and docs
all update node version from 16 to 20
https://github.com/actions/cache/releases/tag/v4.0.0
https://github.com/actions/setup-go/releases/tag/v5.0.0
https://github.com/actions/checkout/releases/tag/v4.0.0
https://github.com/actions/github-script/releases/tag/v7.0.0
https://github.com/actions/upload-artifact/blob/ef09cdac3e2d3e60d8ccadda691f4f1cec5035cb/docs/MIGRATION.md#multiple-uploads-to-the-same-named-artifact
Check List
Tests
Release note