Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: upgrade gin-gonic/gin to v1.10.0 #8646

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Conversation

JmPotato
Copy link
Member

What problem does this PR solve?

Issue Number: close #8643.

What is changed and how does it work?

 Update gin-gonic/gin to v1.10.0 to adopt the latest vulnerability fix.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

Signed-off-by: JmPotato <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 23, 2024
go.mod Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 23, 2024
Signed-off-by: JmPotato <[email protected]>
@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 23, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 23, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-23 09:24:53.814461536 +0000 UTC m=+1471563.554885476: ☑️ agreed by lhy1024.
  • 2024-09-23 09:26:47.978601774 +0000 UTC m=+1471677.719025698: ☑️ agreed by okJiang.

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.66%. Comparing base (bd0d4ff) to head (285c4fb).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8646      +/-   ##
==========================================
+ Coverage   77.63%   77.66%   +0.02%     
==========================================
  Files         474      474              
  Lines       62097    62097              
==========================================
+ Hits        48209    48227      +18     
+ Misses      10340    10325      -15     
+ Partials     3548     3545       -3     
Flag Coverage Δ
unittests 77.66% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot merged commit edb43c0 into tikv:master Sep 23, 2024
25 checks passed
@JmPotato JmPotato deleted the update_gin branch September 23, 2024 09:48
@JmPotato JmPotato added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Sep 23, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #8647.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Sep 23, 2024
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Sep 23, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #8648.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #8649.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Sep 23, 2024
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Sep 23, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #8650.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Sep 23, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #8651.

@lhy1024
Copy link
Contributor

lhy1024 commented Sep 23, 2024

Do we need to cherry-pick it to 5.4?

ti-chi-bot bot pushed a commit that referenced this pull request Sep 23, 2024
close #8643

Update gin-gonic/gin to v1.10.0 to adopt the latest vulnerability fix.

Signed-off-by: JmPotato <[email protected]>

Co-authored-by: JmPotato <[email protected]>
ti-chi-bot bot pushed a commit that referenced this pull request Sep 23, 2024
close #8643

Update gin-gonic/gin to v1.10.0 to adopt the latest vulnerability fix.

Signed-off-by: JmPotato <[email protected]>

Co-authored-by: JmPotato <[email protected]>
ti-chi-bot bot pushed a commit that referenced this pull request Sep 23, 2024
close #8643

Update gin-gonic/gin to v1.10.0 to adopt the latest vulnerability fix.

Signed-off-by: JmPotato <[email protected]>

Co-authored-by: JmPotato <[email protected]>
ti-chi-bot bot pushed a commit that referenced this pull request Sep 23, 2024
close #8643

Update gin-gonic/gin to v1.10.0 to adopt the latest vulnerability fix.

Signed-off-by: JmPotato <[email protected]>

Co-authored-by: JmPotato <[email protected]>
ti-chi-bot bot pushed a commit that referenced this pull request Sep 23, 2024
close #8643

Update gin-gonic/gin to v1.10.0 to adopt the latest vulnerability fix.

Signed-off-by: JmPotato <[email protected]>

Co-authored-by: JmPotato <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update gin-gonic/gin to adopt the latest vulnerability fix
5 participants