pkg: delete config when QPS and concurrency are both deleted #8653
Conversation
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
Signed-off-by: Ryan Leung <[email protected]>
rleungx
force-pushed
the
case-delete
branch
from
514d35a
to
d03c2f1
Compare
ti-chi-bot
bot
added
size/XS
rleungx
changed the title
rleungx
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8653 +/- ##
==========================================
+ Coverage 77.63% 77.65% +0.02%
==========================================
Files 474 474
Lines 62097 62100 +3
==========================================
+ Hits 48209 48224 +15
+ Misses 10340 10327 -13
- Partials 3548 3549 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
| return lim.(*limiter).updateDimensionConfig(cfg) | ||
| status := lim.(*limiter).updateDimensionConfig(cfg) | ||
| if status&QPSDeleted != 0 && status&ConcurrencyDeleted != 0 { | ||
| l.limiters.Delete(label) |
There was a problem hiding this comment.
What will happen if this is not removed?
There was a problem hiding this comment.
leave a config in output that is meaningless
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lhy1024 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: Ref #4373.
What is changed and how does it work?
Check List
Tests
Release note