Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix race due to wrong usage #8655

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Sep 24, 2024

What problem does this PR solve?

Issue Number: Close #8654.

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.74%. Comparing base (6b927e1) to head (35a18ff).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8655      +/-   ##
==========================================
+ Coverage   77.64%   77.74%   +0.10%     
==========================================
  Files         474      474              
  Lines       62105    62105              
==========================================
+ Hits        48220    48286      +66     
+ Misses      10334    10271      -63     
+ Partials     3551     3548       -3     
Flag Coverage Δ
unittests 77.74% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 24, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 24, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-24 06:09:11.024272239 +0000 UTC m=+1546220.764696159: ☑️ agreed by okJiang.
  • 2024-09-24 06:09:59.898387947 +0000 UTC m=+1546269.638811885: ☑️ agreed by lhy1024.

@ti-chi-bot ti-chi-bot bot merged commit 14b3b9d into tikv:master Sep 24, 2024
25 checks passed
@rleungx rleungx deleted the fix-test-2024-28 branch September 24, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data race in TestConfigForward
3 participants