Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: let TestEvictLeaderScheduler run in two modes #8663

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Sep 24, 2024

What problem does this PR solve?

Issue Number: ref #8619

What is changed and how does it work?

Previously, removeStore only takes effect when StoreIDWithRanges has the value. This PR fixes it.

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 24, 2024
Signed-off-by: Ryan Leung <[email protected]>
@rleungx rleungx removed needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Sep 24, 2024
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Sep 24, 2024
@wuhuizuo
Copy link
Contributor

/remove-label needs-cherry-pick-release-5.4

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. and removed needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 77.72%. Comparing base (ec59a71) to head (70171b6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8663      +/-   ##
==========================================
+ Coverage   77.61%   77.72%   +0.10%     
==========================================
  Files         474      474              
  Lines       62115    62112       -3     
==========================================
+ Hits        48211    48275      +64     
+ Misses      10347    10295      -52     
+ Partials     3557     3542      -15     
Flag Coverage Δ
unittests 77.72% <0.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot removed the needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. label Sep 24, 2024
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. label Sep 24, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 24, 2024

@rleungx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-integration-realcluster-test 70171b6 link false /test pull-integration-realcluster-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit f3e9d9a into tikv:master Sep 24, 2024
22 of 25 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Sep 24, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #8664.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #8665.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Sep 24, 2024
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Sep 24, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #8666.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #8667.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Sep 24, 2024
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Sep 24, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #8668.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Sep 24, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #8669.

@MimeLyc
Copy link

MimeLyc commented Sep 24, 2024

/remove-label needs-cherry-pick-release-5.4

@ti-chi-bot ti-chi-bot bot removed the needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants