*: reset prepare checker once the cache is reset #8860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Leung <[email protected]>
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
Signed-off-by: Ryan Leung <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8860 +/- ##
==========================================
- Coverage 75.86% 75.78% -0.09%
==========================================
Files 460 460
Lines 70637 70651 +14
==========================================
- Hits 53591 53540 -51
- Misses 13673 13720 +47
- Partials 3373 3391 +18
Flags with carried forward coverage won't be shown. Click here to find out more. |
lhy1024
approved these changes
Nov 29, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
|
/hold |
ti-chi-bot
bot
added
the
do-not-merge/hold
okJiang
approved these changes
Dec 2, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lhy1024, okJiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
size/L
rleungx
force-pushed
the
reset-prepared
branch
from
e3fea90
to
9101749
Compare
Signed-off-by: Ryan Leung <[email protected]>
rleungx
force-pushed
the
reset-prepared
branch
from
9101749
to
be95f0c
Compare
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
lhy1024
reviewed
Dec 3, 2024
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
lhy1024
reviewed
Dec 3, 2024
| } | ||
|
|
||
| // NewController create a new Controller. | ||
| func NewController(ctx context.Context, cluster sche.CheckerCluster, conf config.CheckerConfigProvider, ruleManager *placement.RuleManager, labeler *labeler.RegionLabeler, opController *operator.Controller) *Controller { | ||
| func NewController(ctx context.Context, cluster sche.CheckerCluster, conf config.CheckerConfigProvider, ruleManager *placement.RuleManager, labeler *labeler.RegionLabeler, opController *operator.Controller, prepareChecker *sche.PrepareChecker) *Controller { |
There was a problem hiding this comment.
BTW, this function has too many parameters. Do we have any good way to solve it?
Comment on lines
-225
to
-234
| if c.ShouldRun(collectWaitTime...) { | ||
| log.Info("coordinator has finished cluster information preparation") | ||
| break | ||
| } | ||
| select { | ||
| case <-ticker.C: | ||
| case <-c.ctx.Done(): | ||
| log.Info("coordinator stops running") | ||
| return | ||
| } |
There was a problem hiding this comment.
Do we need the similar log?
Signed-off-by: Ryan Leung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: Close #8634, might fix #8689
What is changed and how does it work?
Check List
Tests
Release note