client: support dynamic start/stop of the router client #9082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JmPotato <[email protected]>
ti-chi-bot
bot
added
release-note-none
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9082 +/- ##
==========================================
+ Coverage 76.21% 76.29% +0.07%
==========================================
Files 468 468
Lines 71642 71695 +53
==========================================
+ Hits 54600 54697 +97
+ Misses 13620 13591 -29
+ Partials 3422 3407 -15
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
/hold |
ti-chi-bot
bot
added
do-not-merge/hold
JmPotato
force-pushed
the
dynamically_enable_router_client
branch
2 times, most recently
from
2864c73 to
5cbfed2
Compare
JmPotato
removed
the
do-not-merge/hold
Signed-off-by: JmPotato <[email protected]>
JmPotato
force-pushed
the
dynamically_enable_router_client
branch
2 times, most recently
from
3783ad0 to
a3434cb
Compare
Signed-off-by: JmPotato <[email protected]>
JmPotato
force-pushed
the
dynamically_enable_router_client
branch
from
a3434cb to
fe50044
Compare
Signed-off-by: JmPotato <[email protected]>
rleungx
reviewed
Feb 19, 2025
Signed-off-by: JmPotato <[email protected]>
rleungx
approved these changes
Feb 19, 2025
ti-chi-bot
bot
added
needs-1-more-lgtm
Signed-off-by: JmPotato <[email protected]>
JmPotato
force-pushed
the
dynamically_enable_router_client
branch
from
c5e616c to
cdc8823
Compare
okJiang
reviewed
Feb 19, 2025
Signed-off-by: JmPotato <[email protected]>
okJiang
approved these changes
Feb 19, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: okJiang, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #8690.
What is changed and how does it work?
Check List
Tests
Release note