syncer: use task runner to sync region #9159
Open
+52
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: okJiang <[email protected]>
ti-chi-bot
bot
added
do-not-merge/needs-triage-completed
release-note
Signed-off-by: okJiang <[email protected]>
|
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9159 +/- ##
==========================================
- Coverage 76.37% 76.36% -0.02%
==========================================
Files 474 474
Lines 72400 72437 +37
==========================================
+ Hits 55297 55315 +18
- Misses 13644 13657 +13
- Partials 3459 3465 +6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
/hold I will try to test in a real cluster. |
ti-chi-bot
bot
added
the
do-not-merge/hold
lhy1024
reviewed
Mar 24, 2025
| ctx.SyncRegionRunner.RunTask( | ||
| regionID, | ||
| ratelimit.SyncRegionToFollower, | ||
| func(context.Context) { |
There was a problem hiding this comment.
Do we need to add a unit test for it?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lhy1024 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR only fixes the bug; there will still be some delay between the follower and leader regions. In the future, we will increase the concurrency of consumers to alleviate the delay between the follower and leader under these conditions.
Issue Number: Close #9154
What is changed and how does it work?
Check List
Tests
Release note