raftstore:Fix log append reject response bug about MsgUnreachable msg #12409
Conversation
Signed-off-by: tier-cap <[email protected]>
Signed-off-by: tier-cap <[email protected]>
close tikv#11371 Signed-off-by: tier-cap <[email protected]>
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
| @@ -2061,6 +2061,14 @@ where | |||
| return Ok(()); | |||
| } | |||
|
|
|||
| if matches!(msg_type, MessageType::MsgUnreachable) { | |||
There was a problem hiding this comment.
How can it receive the MsgUnreachable? Is there any test case to verify it's actually working?
There was a problem hiding this comment.
by checking whether the progress state to this peer is Probe, is ok?
There was a problem hiding this comment.
No, it's too hacky. The point of making it unreachable is to hint leader don't send any further messages. You should check the behavior instead of checking some properties.
ti-chi-bot
added
size/M
Signed-off-by: tier-cap <[email protected]>
tier-cap
force-pushed
the
fix-log-append-reject-bug
branch
from
4426fb1 to
c0ab628
Compare
Signed-off-by: tier-cap <[email protected]>
tier-cap
changed the title
|
@tier-cap: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ti-chi-bot
added
the
needs-rebase
What is changed and how it works?
Issue Number: Close #11371
What's Changed:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note