-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PD scheduling best practices and glossary #104
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: anotherrachel <[email protected]>
Signed-off-by: anotherrachel <[email protected]>
512d772
to
504a57e
Compare
Signed-off-by: anotherrachel <[email protected]>
Signed-off-by: anotherrachel <[email protected]>
Signed-off-by: anotherrachel <[email protected]>
Signed-off-by: anotherrachel <[email protected]>
Signed-off-by: anotherrachel <[email protected]>
|
||
## L | ||
|
||
### leader/follower/learner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe these can be split up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean they can be introduced separately?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think they can be separate entries in this glossary?
summary: Glossaries about TiKV. | ||
menu: | ||
docs: | ||
parent: Concepts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reference is more appropriate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I think these are some good concept material (reference, too) which users may want to notice easily when they are learning about TiKV.
|
||
- `scheduler show`: Shows currently running schedulers in the system | ||
- `scheduler remove balance-leader-scheduler`: Removes (disable) balance-leader-scheduler | ||
- `scheduler add evict-leader-scheduler-1`: Adds a scheduler to remove all leaders in Store 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this and some further examples you use concrete examples, but above you used [limit]
, can we make it consistent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really appreciate your suggestions. I'll work on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Ana, here I think we can make it consistent by using scheduler add/remove [scheduler name]
but I am not sure with "operator [add | remove]". The examples are concrete, yes, but more accessible to users since this operation usually involves a specific region (or store). What's your opinion?
I feel like most of the first half of this article should probably be something for learning as part of concepts maybe? The rest of it seems to be troubleshooting/issue resolving. It's good and useful stuff. :) But... I'm not really sure where the "Best Practices" part of this article this. It doesn't go into recommending for example, how to improve a PD cluster from the default configuration to one optimized for your needs. It doesn't talk about how to decide which options/topologies are ideal for your needs. It doesn't talk about tradeoffs involved between these options, etc. |
@lilin90 PTAL
|
@Hoverbear Agree with you. Thanks! We'll consider giving some suggestions to those who'll write best practices. |
What is changed?
This PR:
introduction.md
of best practicespd-scheduling.md
to the best practices seriesglossary.md
Any related PRs or issues?
Which version does your change affect?