-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi-version support #114
Conversation
Signed-off-by: Ana Hobden <[email protected]>
Bulma Menus looks cool!!! |
Also is there any feature or content specific to 3.1 beta? |
Not at the moment! We've published 3.1.0-beta though so it makes sense for it to be present and evolve into 3.1 itself. Things we need to add:
|
Signed-off-by: Ana Hobden <[email protected]>
Signed-off-by: Ana Hobden <[email protected]>
Signed-off-by: Ana Hobden <[email protected]>
Signed-off-by: Ana Hobden <[email protected]>
Looking at the preview of Bulma version, I have some questions:
|
Bulma is the CSS framework @lucperkins used to create the TiKV site, it's not just some piece of tech backing our menus, it's the overall look at feel of our entire site. :)
I rather like this way, but if you'd prefer we can collapse them. I did collapse the menus on mobile :)
Bulma doesn't support this out of the box. I might be able to hack on it a bit to add this feature. :)
Apparently Hugo does generate a TOC so maybe (https://gohugo.io/content-management/toc/)! I feel like this is outside of the scope of this PR though? |
Signed-off-by: Ana Hobden <[email protected]>
Fixed :) |
|
Sounds like you're unsatisfied with Bulma's menus! I am too! I'm going to build some menus with something else and we can evaluate that. :) |
Signed-off-by: Ana Hobden <[email protected]>
@dcalvin Can you have a try with https://deploy-preview-114--tikv.netlify.com/docs/3.0/tasks/monitor/key-metrics/ |
This looks good enough to merge. I like it. And I tested it on phone, looking good too. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add multi-version support to website. It's important since we'll soon be posting 3.1/4.0 etc.
This also restructures our menus!
Here's a preview!
Note: No awkward tabs in the hero!
Some notes:
Future work will be: