This repository has been archived by the owner on May 11, 2022. It is now read-only.
subjectreviewaccess call as a namespaced resource #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The objective of this PR is to provide a way to perform namespaced scoped resource based subject access review request based on content of the http request. For instance, an http request may be as follows:
While this http request is directed towards a service, we need to be able to perform authorization over it using k8s RBAC. Thus the objective boils down to filling out subjectaccessreview object using the information in the URL. For instance, we may derive these key value pairs:
namespace: mynamespace1,apiGroup: health.tilda.bio,apiVersion: v1beta1,resource: patientsandname: mypatient33and so on.We will also need to fill in user information, which is already being done, so no change is required there.
In summary, this PR assumes that the service will honor canonical k8s URL formats and performs subject access review request based on the information in the request.
Signed-off-by: Saurabh Deoras [email protected]