Skip to content
This repository has been archived by the owner on Sep 18, 2018. It is now read-only.

Fix requirement versions #444

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jwmarshall
Copy link

This PR will fix various pip module versions in the requirements. I've verified the build via Travis using the tests already in this repo.

https://travis-ci.org/jwmarshall/RatticWeb/builds/130076774

@jwmarshall
Copy link
Author

This resolves issue #405

@jwmarshall
Copy link
Author

@Zemmiph0bia @smarthall I know you guys are really busy but can we at least get this merged so that the current version builds correctly? Thank you.

@angystardust
Copy link

Maybe it's time to fork...
https://github.com/danislav/RatticWeb

@jwmarshall
Copy link
Author

@angystardust the problem with another fork is simply knowing wether or not the person(s) plan to keep supporting it or if they've only forked it to only fix one issue.

@Zemmiph0bia @smarthall perhaps we could add some additional contributors to this project to help manage incoming pull requests?

All things considered I've tested my PR several times, and have since deployed my fork to production with zero issues, not to mention it passes in TravisCI which your current master branch does not. Would love to see this merged soon. You mentioned on twitter late last year that this was not a dead project, please merge this PR so it can also be a working project.

@jwmarshall
Copy link
Author

Considering this is still open and nobody with access to the repo has even commented this project is pretty much dead in all the ways that matter.

@jwmarshall
Copy link
Author

jwmarshall commented Aug 15, 2016

Three months now with no answers 👎

@orsenthil
Copy link

@jwmarshall - is your fork building or running tests successful? Anyone who is going to try is going to hit with the build problem and possibly going to stumble upon this discussion.

@orsenthil
Copy link

Actually, if you rebase and push it, you can encounter failures.

On local setup, I hit this problem.

$ ./runtests.sh
Running PEP8 (pep8 --exclude=migrations,lib,static,.ropeproject --ignore=E501,E225,E128,E124 .)...  [30486 refs]
Success
Running pyflakes (./pyflakes.sh)...  [77070 refs]
Success
Running Unit Tests (./manage.py test )...  Traceback (most recent call last):
  File "./manage.py", line 10, in <module>
    execute_from_command_line(sys.argv)
  File "/Users/senthil/python2.7/ratticweb/lib/python2.7/site-packages/django/core/management/__init__.py", line 399, in execute_from_command_line
    utility.execute()
  File "/Users/senthil/python2.7/ratticweb/lib/python2.7/site-packages/django/core/management/__init__.py", line 392, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/Users/senthil/python2.7/ratticweb/lib/python2.7/site-packages/django/core/management/__init__.py", line 272, in fetch_command
    klass = load_command_class(app_name, subcommand)
  File "/Users/senthil/python2.7/ratticweb/lib/python2.7/site-packages/django/core/management/__init__.py", line 75, in load_command_class
    module = import_module('%s.management.commands.%s' % (app_name, name))
  File "/Users/senthil/python2.7/ratticweb/lib/python2.7/site-packages/django/utils/importlib.py", line 40, in import_module
    __import__(name)
  File "/Users/senthil/python2.7/ratticweb/lib/python2.7/site-packages/django_nose/__init__.py", line 5, in <module>
    from django_nose.runner import BasicNoseRunner, NoseTestSuiteRunner
  File "/Users/senthil/python2.7/ratticweb/lib/python2.7/site-packages/django_nose/runner.py", line 19, in <module>
    from django import setup
ImportError: cannot import name setup
[113203 refs]
Failure

@jwmarshall
Copy link
Author

I simply ran the tests as they existed in the repository. Did you make sure to install the various requirements?

Have a look at the .travis.yml to see the exact commands and steps used for testing.

https://github.com/tildaslash/RatticWeb/blob/master/.travis.yml

@orsenthil
Copy link

Actually, lots has changed that those .trave.yml is no longer valid. ( For e.g: #454 )

or you can try it by pushing an empty commit to this same PR and trying to build again.

@jwmarshall jwmarshall closed this Sep 20, 2016
@jwmarshall jwmarshall reopened this Sep 20, 2016
@jwmarshall
Copy link
Author

Closed and reopened to test. Indeed the checks have failed. I will have to review what changes were made since this PR was opened. I'm honestly surprised that any were made without anyone even looking at this PR for months.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants