-
Notifications
You must be signed in to change notification settings - Fork 149
Fix requirement versions #444
base: master
Are you sure you want to change the base?
Conversation
This resolves issue #405 |
@Zemmiph0bia @smarthall I know you guys are really busy but can we at least get this merged so that the current version builds correctly? Thank you. |
Maybe it's time to fork... |
@angystardust the problem with another fork is simply knowing wether or not the person(s) plan to keep supporting it or if they've only forked it to only fix one issue. @Zemmiph0bia @smarthall perhaps we could add some additional contributors to this project to help manage incoming pull requests? All things considered I've tested my PR several times, and have since deployed my fork to production with zero issues, not to mention it passes in TravisCI which your current master branch does not. Would love to see this merged soon. You mentioned on twitter late last year that this was not a dead project, please merge this PR so it can also be a working project. |
Considering this is still open and nobody with access to the repo has even commented this project is pretty much dead in all the ways that matter. |
Three months now with no answers 👎 |
@jwmarshall - is your fork building or running tests successful? Anyone who is going to try is going to hit with the build problem and possibly going to stumble upon this discussion. |
Actually, if you rebase and push it, you can encounter failures. On local setup, I hit this problem.
|
I simply ran the tests as they existed in the repository. Did you make sure to install the various requirements? Have a look at the https://github.com/tildaslash/RatticWeb/blob/master/.travis.yml |
Actually, lots has changed that those .trave.yml is no longer valid. ( For e.g: #454 ) or you can try it by pushing an empty commit to this same PR and trying to build again. |
Closed and reopened to test. Indeed the checks have failed. I will have to review what changes were made since this PR was opened. I'm honestly surprised that any were made without anyone even looking at this PR for months. |
This PR will fix various pip module versions in the requirements. I've verified the build via Travis using the tests already in this repo.
https://travis-ci.org/jwmarshall/RatticWeb/builds/130076774