rspec-cleanup (#274)

no need to require spec helper explicitly when it's in .rspec 🎯
tilo · Mar 9, 2024 · 77a9ac5 · 77a9ac5
1 parent 2f264ca
commit 77a9ac5
Show file tree

Hide file tree

Showing 49 changed files with 1 addition and 96 deletions.
diff --git a/.rspec b/.rspec
@@ -0,0 +1 @@
+--require spec_helper
diff --git a/spec/features/binary/binary_file_spec.rb b/spec/features/binary/binary_file_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 # this reads a binary database dump file, which is in structure like a CSV file

diff --git a/spec/features/chunked/chunked_reading_spec.rb b/spec/features/chunked/chunked_reading_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 describe 'chunked reading' do

diff --git a/spec/features/chunked/chunked_spec.rb b/spec/features/chunked/chunked_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 class Processor

diff --git a/spec/features/converters/convert_values_to_numeric_spec.rb b/spec/features/converters/convert_values_to_numeric_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 describe 'numeric conversion of values' do

diff --git a/spec/features/converters/value_converters_spec.rb b/spec/features/converters/value_converters_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 require 'date'

diff --git a/spec/features/formating/bom_issues_spec.rb b/spec/features/formating/bom_issues_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 describe 'BOM Tests' do

diff --git a/spec/features/formating/carriage_return_spec.rb b/spec/features/formating/carriage_return_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 describe 'process files with line endings explicitly pre-specified' do

diff --git a/spec/features/formating/column_separator_spec.rb b/spec/features/formating/column_separator_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 describe 'can handle col_sep' do

diff --git a/spec/features/formating/emoji_spec.rb b/spec/features/formating/emoji_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 [true, false].each do |bool|

diff --git a/spec/features/formating/line_ending_spec.rb b/spec/features/formating/line_ending_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 describe 'process files with line endings explicitly pre-specified' do

diff --git a/spec/features/formating/valid_unicode_spec.rb b/spec/features/formating/valid_unicode_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 describe 'valid unicode' do

diff --git a/spec/features/general/additional_separator_spec.rb b/spec/features/general/additional_separator_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 describe 'handling of additional trailing column separators' do

diff --git a/spec/features/general/basic_spec.rb b/spec/features/general/basic_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 [true, false].each do |bool|

diff --git a/spec/features/general/empty_columns_spec.rb b/spec/features/general/empty_columns_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 describe 'can handle empty columns' do

diff --git a/spec/features/general/simple_spec.rb b/spec/features/general/simple_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 describe 'handling files with one column' do

diff --git a/spec/features/hash_transformations/remove_empty_values_spec.rb b/spec/features/hash_transformations/remove_empty_values_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 describe ':remove_empty_values option' do

diff --git a/spec/features/hash_transformations/remove_keys_from_hashes_spec.rb b/spec/features/hash_transformations/remove_keys_from_hashes_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 describe ':remove_zero_values option' do

diff --git a/spec/features/hash_transformations/remove_not_mapped_keys_spec.rb b/spec/features/hash_transformations/remove_not_mapped_keys_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 describe ':remove_unmapped_keys option' do

diff --git a/spec/features/hash_transformations/remove_values_matching_spec.rb b/spec/features/hash_transformations/remove_values_matching_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 describe ':remove_values_matching option' do

diff --git a/spec/features/hash_transformations/remove_zero_values_spec.rb b/spec/features/hash_transformations/remove_zero_values_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 describe ':remove_zero_values option' do

diff --git a/spec/features/header_handling/duplicate_headers_spec.rb b/spec/features/header_handling/duplicate_headers_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 describe 'duplicate headers' do

diff --git a/spec/features/header_handling/header_transformation_spec.rb b/spec/features/header_handling/header_transformation_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 describe 'header transformations option' do

diff --git a/spec/features/header_handling/invalid_headers_spec.rb b/spec/features/header_handling/invalid_headers_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 #

diff --git a/spec/features/header_handling/keep_headers_spec.rb b/spec/features/header_handling/keep_headers_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 describe ':keep_original_headers option' do

diff --git a/spec/features/header_handling/key_mapping_spec.rb b/spec/features/header_handling/key_mapping_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 describe 'key_mapping' do

diff --git a/spec/features/header_handling/no_header_spec.rb b/spec/features/header_handling/no_header_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 describe 'no header in file' do

diff --git a/spec/features/header_handling/not_downcase_header_spec.rb b/spec/features/header_handling/not_downcase_header_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 describe ':downcase_header option' do

diff --git a/spec/features/header_handling/required_headers_spec.rb b/spec/features/header_handling/required_headers_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 describe 'required_headers -> required_keys' do

diff --git a/spec/features/header_handling/silence_missing_keys_spec.rb b/spec/features/header_handling/silence_missing_keys_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 describe 'silence missing keys' do

diff --git a/spec/features/header_handling/strings_as_keys_spec.rb b/spec/features/header_handling/strings_as_keys_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 describe ':strings_as_keys option' do

diff --git a/spec/features/header_handling/strip_chars_from_headers_spec.rb b/spec/features/header_handling/strip_chars_from_headers_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 describe ':strip_chars_from_headers option' do

diff --git a/spec/features/ignore_comments_spec.rb b/spec/features/ignore_comments_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 describe ':comment_regexp option' do

diff --git a/spec/features/quotes/escaped_quote_chars_spec.rb b/spec/features/quotes/escaped_quote_chars_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 [true, false].each do |bool|

diff --git a/spec/features/quotes/quoted_spec.rb b/spec/features/quotes/quoted_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 describe 'loading file with quoted fields' do

diff --git a/spec/features/skip_lines_spec.rb b/spec/features/skip_lines_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 describe ':skip_lines option' do

diff --git a/spec/features/special_cases/hard_sample_spec.rb b/spec/features/special_cases/hard_sample_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 describe 'can handle the difficult CSV file' do

diff --git a/spec/features/special_cases/malformed_spec.rb b/spec/features/special_cases/malformed_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 # according to RFC-4180 quotes inside of "words" shouldbe doubled, but our parser is robust against that.

diff --git a/spec/features/special_cases/problematic_spec.rb b/spec/features/special_cases/problematic_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 describe 'loading file with UTF-8 characters in the header' do

diff --git a/spec/features/special_cases/trading_spec.rb b/spec/features/special_cases/trading_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 # somebody reported that a column called 'options_trader' would be truncated to 'trader'

diff --git a/spec/smarter_csv/blank_spec.rb b/spec/smarter_csv/blank_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 describe 'blank?' do
   it 'is true for nil' do
     expect(SmarterCSV.send(:blank?, nil)).to eq true

diff --git a/spec/smarter_csv/close_file_spec.rb b/spec/smarter_csv/close_file_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 describe 'file operations' do

diff --git a/spec/smarter_csv/file_encoding_spec.rb b/spec/smarter_csv/file_encoding_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 RSpec.describe SmarterCSV do
   describe 'encoding warning message' do
     let(:file_path) { 'path/to/csvfile.csv' }

diff --git a/spec/smarter_csv/option_validations_spec.rb b/spec/smarter_csv/option_validations_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 fixture_path = 'spec/fixtures'
 
 describe 'option validations' do

diff --git a/spec/smarter_csv/options_processing_spec.rb b/spec/smarter_csv/options_processing_spec.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 describe 'options processing' do
   describe '#process_options' do
     it 'prints out given options in verbose mode' do

diff --git a/spec/smarter_csv/parse/column_separator_spec.rb b/spec/smarter_csv/parse/column_separator_spec.rb
@@ -12,8 +12,6 @@
 #   code paths are behaving identically.
 # ------------------------------------------------------------------------------------------
 
-require 'spec_helper'
-
 [true, false].each do |bool|
   describe "fulfills RFC-4180 and more with#{bool ? ' C-' : 'out '}acceleration" do
     describe 'parse with col_sep' do

diff --git a/spec/smarter_csv/parse/max_size_spec.rb b/spec/smarter_csv/parse/max_size_spec.rb
@@ -12,8 +12,6 @@
 #   code paths are behaving identically.
 # ------------------------------------------------------------------------------------------
 
-require 'spec_helper'
-
 # the purpose of the max_size parameter is to handle a corner case where
 # CSV lines contain more fields than the header.
 # In which case the remaining fields in the line are ignored

diff --git a/spec/smarter_csv/parse/old_csv_library_spec.rb b/spec/smarter_csv/parse/old_csv_library_spec.rb
@@ -12,8 +12,6 @@
 #   code paths are behaving identically.
 # ------------------------------------------------------------------------------------------
 
-require 'spec_helper'
-
 [true, false].each do |bool|
   describe "fulfills RFC-4180 and more with#{bool ? ' C-' : 'out '}acceleration" do
     describe 'old CSV library parsing tests' do

diff --git a/spec/smarter_csv/parse/rfc4180_and_more_spec.rb b/spec/smarter_csv/parse/rfc4180_and_more_spec.rb
@@ -12,8 +12,6 @@
 #   code paths are behaving identically.
 # ------------------------------------------------------------------------------------------
 
-require 'spec_helper'
-
 [true, false].each do |bool|
   describe "fulfills RFC-4180 and more with#{bool ? ' C-' : 'out '}acceleration" do
     let(:options) { {col_sep: ',', row_sep: $INPUT_RECORD_SEPARATOR, quote_char: '"', acceleration: bool } }