reflowed CSS and html classes… #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… site look really good on mobile and various sized browsers
georgejhunt
pushed a commit
to georgejhunt/iiab-menu-old-tim
that referenced
this pull request
Nov 22, 2018
Additional Menu Items
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reflowed CSS and html classes to utilize bootstrap fully and make the site look really good on mobile and various sized browsers.
By using col-12, col-8, ect., we have more control over columns without having to use tables. Tables allow text to overflow their grid unfortunately and has prevented us in the past from allowing the body to go below 1200px width.
I started over with the CSS file, copies some styles over, but essentially let Bootstrap do the heavy lifting.
Side effects: xtra_html can literally be anything. So it's impossible for me to predict and counter for that. Since xtra_html was made after the original theme, it's catered to the original theme and will look off with my changes. Keep that in mind. I don't mind going into the xtra_htmls in the JSONs and fixing that as well. But this commit I wanted to be a small as possible.