Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new public API #19

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Conversation

ikrivosheev
Copy link

@ikrivosheev ikrivosheev commented Jul 27, 2022

@tim-weis hello! Thank you for the great library! My use case: I need to get VBA macros from DOC, XLS containers.

Changes:

  • add new public API which get CompoundFile and root path in a container to VBA project
  • Add method Package::into_inner
  • Upgrade cfb dependence up to 0.7
  • Upgrade nom dependence up to 7.1

@tim-weis
Copy link
Owner

Glad to hear that you find this library useful, Ivan. I haven't found time to look into this PR in detail; at a cursory look it appears to be a useful extension. I'll leave a proper review as time permits (Saturday night, or on Sunday).

In the meantime, could you open a new issue that explains your use case and why it's not currently supported by this library? Having an associated issue makes maintenance easier, and is valuable documentation, too.

@ikrivosheev
Copy link
Author

Glad to hear that you find this library useful, Ivan. I haven't found time to look into this PR in detail; at a cursory look it appears to be a useful extension. I'll leave a proper review as time permits (Saturday night, or on Sunday).

In the meantime, could you open a new issue that explains your use case and why it's not currently supported by this library? Having an associated issue makes maintenance easier, and is valuable documentation, too.

Thank you for replay! I have some ideas to improve the library. I will create new issues and PR)

@ikrivosheev ikrivosheev mentioned this pull request Aug 8, 2022
@ikrivosheev
Copy link
Author

ikrivosheev commented Aug 8, 2022

Glad to hear that you find this library useful, Ivan. I haven't found time to look into this PR in detail; at a cursory look it appears to be a useful extension. I'll leave a proper review as time permits (Saturday night, or on Sunday).

In the meantime, could you open a new issue that explains your use case and why it's not currently supported by this library? Having an associated issue makes maintenance easier, and is valuable documentation, too.

Done: #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants