Skip to content

Commit

Permalink
Remove unnecessary definitions in Makefile.PL
Browse files Browse the repository at this point in the history
These 2 NYTPROF_* targets don't need to be defined outside the scope of
a particular 'make' target.  Defining them may interfere with, e.g.,
.appveyor.yml.
  • Loading branch information
jkeenan committed Apr 30, 2021
1 parent 8e3af69 commit 14899c9
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
2 changes: 0 additions & 2 deletions Makefile.PL
Original file line number Diff line number Diff line change
Expand Up @@ -283,8 +283,6 @@ perltidy:
ctidy_bcpp:
bcpp -f 2 -i 4 -bcl -qb 10 -ylcnc -yb NYTProf.xs
NYTPROF_AUTHOR_TESTING=""
NYTPROF_TEST_SHORT=""
test_short:
NYTPROF_TEST_SHORT=1 NYTPROF_AUTHOR_TESTING=1 make test
Expand Down
7 changes: 6 additions & 1 deletion t/90-pod.t
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
#!perl -w

use Test::More;
plan skip_all => "NYTPROF_AUTHOR_TESTING only" unless $ENV{NYTPROF_AUTHOR_TESTING};
unless ($ENV{NYTPROF_AUTHOR_TESTING}) {
plan skip_all => "NYTPROF_AUTHOR_TESTING only";
}
else {
diag("Relevant envvar is true; proceeding to testing POD");
}

eval "use Test::Pod 1.00";
plan skip_all => "Test::Pod 1.00 required for testing POD" if $@;
Expand Down

0 comments on commit 14899c9

Please sign in to comment.