completely remove floatthead #197
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed all code that initializes the plugin (doing this under the assumption that timbunce#194 removes the js file from this project). Also removed `show_fragment_target()` because it would no longer work without floatthead present. This fixes timbunce#192 , or at least fixes the fix that was made in it. The proper way to fix timbunce#192 would be to take a look at the `show_fragment_target()` function and figure out why its setting the incorrect scrollTop there when you click on links. I cannot do this without seeing the generated code. Either way, someone needs to test this change before merging it, because I have not done so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed all code that initializes the plugin (doing this under the assumption that #194 removes the js file from this project).
Also removed
show_fragment_target()because it would no longer work without floatthead present.This fixes #192 , or at least fixes the fix that was made in it.
The proper way to fix #192 would be to take a look at the
show_fragment_target()function and figure out why its setting the incorrect scrollTop there when you click on links. I cannot do this without seeing the generated code.Either way, someone needs to test this change before merging it, because I have not done so.